You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/07/12 09:50:06 UTC

[GitHub] [incubator-openwhisk] sven-lange-last commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules

sven-lange-last commented on issue #4555: [WIP] [Scheduler] Add Etcd installation & modules
URL: https://github.com/apache/incubator-openwhisk/pull/4555#issuecomment-510825951
 
 
   My general comment on this PR is that it unconditionally adds system tests like `EtcdClientTests` that require a deployed etcd. In the dev mailing list discussion, a feature flag was requested for the architecture change: https://lists.apache.org/thread.html/63696c7bee9effb57118fe24513789d5538ea3a64af1204fccde73e8@%3Cdev.openwhisk.apache.org%3E.
   
   By default, etcd should not be deployed and tests requiring etcd should not be run.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services