You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/30 23:58:12 UTC

[GitHub] [incubator-pinot] Jackie-Jiang edited a comment on issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders

Jackie-Jiang edited a comment on issue #6726:
URL: https://github.com/apache/incubator-pinot/issues/6726#issuecomment-810628574


   (Optional) For the 3rd TODO, we may simplify the code by replacing `setColumn(int colId, int value)` to `putValue(int value)` because we always put values one by one. Performance difference might not be huge, but should be cleaner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org