[tez] branch master updated: TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test (#267) (Laszlo Bodor reviewed by Rajesh Balamohan)

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

abstractdog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tez.git


The following commit(s) were added to refs/heads/master by this push:
     new 97cc788ce TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test (#267) (Laszlo Bodor reviewed by Rajesh Balamohan)
97cc788ce is described below

commit 97cc788ce6743dbfcd3d0eac9c4d6272fdaa3ba9
Author: Bodor Laszlo <bo...@gmail.com>
AuthorDate: Tue Feb 14 09:09:01 2023 +0100

    TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test (#267) (Laszlo Bodor reviewed by Rajesh Balamohan)
---
 .../src/test/java/org/apache/tez/test/TestLocalMode.java      | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java
index 00125fd54..14832d36c 100644
--- a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java
+++ b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java
@@ -62,6 +62,12 @@ import static org.junit.Assert.*;
 @RunWith(Parameterized.class)
 public class TestLocalMode {
 
+  /**
+   * In order to be able to safely get VertexStatus from a running DAG,
+   * the DAG needs to run for a certain amount of time, see TEZ-4475 for details.
+   */
+  private static final int SLEEP_PROCESSOR_TIME_TO_SLEEP_MS = 500;
+
   private static final File STAGING_DIR = new File(System.getProperty("test.build.data"),
       TestLocalMode.class.getName());
 
@@ -255,8 +261,9 @@ public class TestLocalMode {
   }
 
   private DAG createSimpleDAG(String dagName, String processorName) {
-    DAG dag = DAG.create(dagName).addVertex(Vertex.create(SleepProcessor.SLEEP_VERTEX_NAME, ProcessorDescriptor
-        .create(processorName).setUserPayload(new SleepProcessor.SleepProcessorConfig(1).toUserPayload()), 1));
+    DAG dag = DAG.create(dagName).addVertex(
+        Vertex.create(SleepProcessor.SLEEP_VERTEX_NAME, ProcessorDescriptor.create(processorName).setUserPayload(
+            new SleepProcessor.SleepProcessorConfig(SLEEP_PROCESSOR_TIME_TO_SLEEP_MS).toUserPayload()), 1));
     return dag;
   }