You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/22 09:26:21 UTC
[GitHub] [apisix] membphis opened a new pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…
membphis opened a new pull request #2099:
URL: https://github.com/apache/apisix/pull/2099
…rification
with other parameters.
### What this PR does / why we need it:
fix #2084
```
=== TEST 4: get plugin node-status schema
--- request
GET /apisix/admin/plugins/node-status
--- response_body
{"additionalProperties":false,"type":"object"}
--- no_error_log
[error]
=== TEST 5: get plugin prometheus schema
--- request
GET /apisix/admin/plugins/prometheus
--- response_body
{"properties":{"disable":{"type":"boolean"}},"additionalProperties":false,"type":"object"}
--- no_error_log
[error]
```
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2099:
URL: https://github.com/apache/apisix/pull/2099#issuecomment-694025952
@nic-chen do you have time to review this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2099:
URL: https://github.com/apache/apisix/pull/2099#discussion_r490067745
##########
File path: t/admin/plugins.t
##########
@@ -61,6 +61,16 @@ GET /apisix/admin/plugins/limit-req
--- request
GET /apisix/admin/plugins/node-status
--- response_body
-{"additionalProperties":false,"type":"object"}
+{"properties":{"disable":{"type":"boolean"}},"additionalProperties":false,"type":"object"}
Review comment:
@membphis Not working currently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2099:
URL: https://github.com/apache/apisix/pull/2099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org