You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/10 02:03:37 UTC

[GitHub] [beam] amaliujia edited a comment on pull request #13898: [BEAM-11747] Make BeamCalcRel safe for ZetaSQL

amaliujia edited a comment on pull request #13898:
URL: https://github.com/apache/beam/pull/13898#issuecomment-776378220


   I am still not sure why we should reject Int64 type for UDF.
   
   Assuming a UDF is defined as `package com.xxx.client; class name; public Long udf(Long a)`, the code gen will generate code for UDF like `Long n = com.xxx.client.name.udf((Long) value)`.
   
   In this case, the value is from Row thus is compatible with ZetaSQL, the return value is still Java object which is also be compatible with ZetaSQL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org