You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Matt Stephenson <ma...@apache.org> on 2013/05/25 00:48:41 UTC
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Shouldn't the author be Tang Yong instead of Andrew Phillips?
On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
> Updated Branches:
> refs/heads/1.6.x a67afcb21 -> a0232b09b
>
>
> JCLOUDS-68: Correcting Keystone feature description
> Submitted by Tang Yong
>
>
> Project:
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
>
> Branch: refs/heads/1.6.x
> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
> Parents: a67afcb
> Author: Andrew Phillips <an...@apache.org>
> Authored: Thu May 23 18:30:24 2013 +0200
> Committer: Andrew Phillips <an...@apache.org>
> Committed: Fri May 24 17:20:04 2013 -0400
>
> ----------------------------------------------------------------------
> feature/src/main/resources/feature.xml | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
> ----------------------------------------------------------------------
> diff --git a/feature/src/main/resources/feature.xml
> b/feature/src/main/resources/feature.xml
> index 4a29491..d32d340 100644
> --- a/feature/src/main/resources/feature.xml
> +++ b/feature/src/main/resources/feature.xml
> @@ -92,7 +92,7 @@ limitations under the License.
>
> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
> </feature>
>
> - <feature name='jclouds-api-openstack-keystone' description='JClouds -
> API - OpenStack Nova' version='${project.version}' resolver='(obr)'>
> + <feature name='jclouds-api-openstack-keystone' description='JClouds -
> API - OpenStack Keystone' version='${project.version}' resolver='(obr)'>
> <feature version='${project.version}'>jclouds</feature>
>
> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
> </feature>
>
>
Re: git commit: JCLOUDS-68: Correcting Keystone feature
description Submitted by Tang Yong
Posted by Andrew Phillips <ap...@qrmedia.com>.
> Shouldn't the author be Tang Yong instead of Andrew Phillips?
I wondered about that too. This format was on the informal advice of
Olivier after a question from me:
> As long as the contribution is attached to a jira I consider implicit
> the contributor agree on the Apache license for the code he provide.
> ...
> Comment sample I would use here (sure we can define the commit
> comment format).
>
> [JCLOUDS-69] after executing jclouds:compute-service-create ,
> FileNotFoundException happened in karaf's log file
> Submitted by Tang Yong
> if patch modified: Patch modified with the reason.
>
> Usually I add the contributor name in the <contributors> section of the pom.
Obviously, fully agree that we should make sure that this in handled
"properly", so advice on a more suitable process/format appreciated.
Bring on the wiki! ;-)
Add a PR to add Tang Yong to <contributors>? Fully agree with Andrew G
that we definitely want to give credit where credit is due!
ap
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Posted by Matt Stephenson <ma...@mattstep.net>.
I believe there is a requirement for at least the email address as well as
the name for tracing IP contributions back to a CLA that covers it.
Currently the commit only has the name. I'm pointing out that there may
be a legal issue here. I don't think this is that big of a deal, but we
should be careful and diligent, as we have a responsibility to the
foundation to do so.
Matt
On Fri, May 24, 2013 at 3:51 PM, Andrew Bayer <an...@gmail.com>wrote:
> Ideally, yes - but we need to document what the preferred procedure is for
> non-committer pull requests (which we should do, since we now have a wiki!)
> so I'm personally not particularly chuffed at this in the meantime.
>
> A.
>
> On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <mattstep@apache.org
> >wrote:
>
> > Shouldn't the author be Tang Yong instead of Andrew Phillips?
> >
> >
> > On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
> >
> >> Updated Branches:
> >> refs/heads/1.6.x a67afcb21 -> a0232b09b
> >>
> >>
> >> JCLOUDS-68: Correcting Keystone feature description
> >> Submitted by Tang Yong
> >>
> >>
> >> Project:
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
> >> Commit:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
> >> Tree:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
> >> Diff:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
> >>
> >> Branch: refs/heads/1.6.x
> >> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
> >> Parents: a67afcb
> >> Author: Andrew Phillips <an...@apache.org>
> >> Authored: Thu May 23 18:30:24 2013 +0200
> >> Committer: Andrew Phillips <an...@apache.org>
> >> Committed: Fri May 24 17:20:04 2013 -0400
> >>
> >> ----------------------------------------------------------------------
> >> feature/src/main/resources/feature.xml | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >>
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
> >> ----------------------------------------------------------------------
> >> diff --git a/feature/src/main/resources/feature.xml
> >> b/feature/src/main/resources/feature.xml
> >> index 4a29491..d32d340 100644
> >> --- a/feature/src/main/resources/feature.xml
> >> +++ b/feature/src/main/resources/feature.xml
> >> @@ -92,7 +92,7 @@ limitations under the License.
> >>
> >>
> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
> >> </feature>
> >>
> >> - <feature name='jclouds-api-openstack-keystone' description='JClouds
> >> - API - OpenStack Nova' version='${project.version}' resolver='(obr)'>
> >> + <feature name='jclouds-api-openstack-keystone' description='JClouds
> >> - API - OpenStack Keystone' version='${project.version}'
> resolver='(obr)'>
> >> <feature version='${project.version}'>jclouds</feature>
> >>
> >>
> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
> >> </feature>
> >>
> >>
> >
>
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Posted by Matt Stephenson <ma...@apache.org>.
Well, I agree. This is obviously something we should get a mentor to look
at once we have a wiki page to be sure we're going to make all lawyercats
happy.
On Fri, May 24, 2013 at 4:18 PM, Ignasi <ig...@gmail.com> wrote:
> Also we should recommend using "git format-patch" instead of "git
> diff" when attaching patches to JIRAs. This way the patch includes the
> author's name and email, and applying it with "git am" will preserve
> both.
>
> I'll make sure to add that in the wiki, if you agree.
>
>
>
> On 25 May 2013 00:57, Andrew Gaul <ga...@apache.org> wrote:
> > For @timuralp recent commit, I added his GitHub repo as a remote,
> > cherry-picked the branch, then pushed. This required a little more work
> > but I think contributors like seeing their names in the clouds.
> >
> > On Fri, May 24, 2013 at 03:51:06PM -0700, Andrew Bayer wrote:
> >> Ideally, yes - but we need to document what the preferred procedure is
> for
> >> non-committer pull requests (which we should do, since we now have a
> wiki!)
> >> so I'm personally not particularly chuffed at this in the meantime.
> >>
> >> A.
> >>
> >> On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <mattstep@apache.org
> >wrote:
> >>
> >> > Shouldn't the author be Tang Yong instead of Andrew Phillips?
> >> >
> >> >
> >> > On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
> >> >
> >> >> Updated Branches:
> >> >> refs/heads/1.6.x a67afcb21 -> a0232b09b
> >> >>
> >> >>
> >> >> JCLOUDS-68: Correcting Keystone feature description
> >> >> Submitted by Tang Yong
> >> >>
> >> >>
> >> >> Project:
> >> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
> >> >> Commit:
> >> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
> >> >> Tree:
> >> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
> >> >> Diff:
> >> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
> >> >>
> >> >> Branch: refs/heads/1.6.x
> >> >> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
> >> >> Parents: a67afcb
> >> >> Author: Andrew Phillips <an...@apache.org>
> >> >> Authored: Thu May 23 18:30:24 2013 +0200
> >> >> Committer: Andrew Phillips <an...@apache.org>
> >> >> Committed: Fri May 24 17:20:04 2013 -0400
> >> >>
> >> >>
> ----------------------------------------------------------------------
> >> >> feature/src/main/resources/feature.xml | 2 +-
> >> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> >>
> ----------------------------------------------------------------------
> >> >>
> >> >>
> >> >>
> >> >>
> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
> >> >>
> ----------------------------------------------------------------------
> >> >> diff --git a/feature/src/main/resources/feature.xml
> >> >> b/feature/src/main/resources/feature.xml
> >> >> index 4a29491..d32d340 100644
> >> >> --- a/feature/src/main/resources/feature.xml
> >> >> +++ b/feature/src/main/resources/feature.xml
> >> >> @@ -92,7 +92,7 @@ limitations under the License.
> >> >>
> >> >>
> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
> >> >> </feature>
> >> >>
> >> >> - <feature name='jclouds-api-openstack-keystone'
> description='JClouds
> >> >> - API - OpenStack Nova' version='${project.version}'
> resolver='(obr)'>
> >> >> + <feature name='jclouds-api-openstack-keystone'
> description='JClouds
> >> >> - API - OpenStack Keystone' version='${project.version}'
> resolver='(obr)'>
> >> >> <feature version='${project.version}'>jclouds</feature>
> >> >>
> >> >>
> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
> >> >> </feature>
> >> >>
> >> >>
> >> >
> >
> > --
> > Andrew Gaul
> > http://gaul.org/
>
Re: git commit: JCLOUDS-68: Correcting Keystone feature
description Submitted by Tang Yong
Posted by Andrew Phillips <ap...@qrmedia.com>.
> Also we should recommend using "git format-patch" instead of "git
> diff" when attaching patches to JIRAs. This way the patch includes the
> author's name and email, and applying it with "git am" will preserve
> both.
Thanks for the reminder. Have been using <github-pr-url>.patch so far,
which seems to be the same as format-patch. But "git cherry-pick" does
*not* do that, I guess...
ap
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Posted by Ignasi <ig...@gmail.com>.
Also we should recommend using "git format-patch" instead of "git
diff" when attaching patches to JIRAs. This way the patch includes the
author's name and email, and applying it with "git am" will preserve
both.
I'll make sure to add that in the wiki, if you agree.
On 25 May 2013 00:57, Andrew Gaul <ga...@apache.org> wrote:
> For @timuralp recent commit, I added his GitHub repo as a remote,
> cherry-picked the branch, then pushed. This required a little more work
> but I think contributors like seeing their names in the clouds.
>
> On Fri, May 24, 2013 at 03:51:06PM -0700, Andrew Bayer wrote:
>> Ideally, yes - but we need to document what the preferred procedure is for
>> non-committer pull requests (which we should do, since we now have a wiki!)
>> so I'm personally not particularly chuffed at this in the meantime.
>>
>> A.
>>
>> On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <ma...@apache.org>wrote:
>>
>> > Shouldn't the author be Tang Yong instead of Andrew Phillips?
>> >
>> >
>> > On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
>> >
>> >> Updated Branches:
>> >> refs/heads/1.6.x a67afcb21 -> a0232b09b
>> >>
>> >>
>> >> JCLOUDS-68: Correcting Keystone feature description
>> >> Submitted by Tang Yong
>> >>
>> >>
>> >> Project:
>> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
>> >> Commit:
>> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
>> >> Tree:
>> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
>> >> Diff:
>> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
>> >>
>> >> Branch: refs/heads/1.6.x
>> >> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
>> >> Parents: a67afcb
>> >> Author: Andrew Phillips <an...@apache.org>
>> >> Authored: Thu May 23 18:30:24 2013 +0200
>> >> Committer: Andrew Phillips <an...@apache.org>
>> >> Committed: Fri May 24 17:20:04 2013 -0400
>> >>
>> >> ----------------------------------------------------------------------
>> >> feature/src/main/resources/feature.xml | 2 +-
>> >> 1 files changed, 1 insertions(+), 1 deletions(-)
>> >> ----------------------------------------------------------------------
>> >>
>> >>
>> >>
>> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
>> >> ----------------------------------------------------------------------
>> >> diff --git a/feature/src/main/resources/feature.xml
>> >> b/feature/src/main/resources/feature.xml
>> >> index 4a29491..d32d340 100644
>> >> --- a/feature/src/main/resources/feature.xml
>> >> +++ b/feature/src/main/resources/feature.xml
>> >> @@ -92,7 +92,7 @@ limitations under the License.
>> >>
>> >> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
>> >> </feature>
>> >>
>> >> - <feature name='jclouds-api-openstack-keystone' description='JClouds
>> >> - API - OpenStack Nova' version='${project.version}' resolver='(obr)'>
>> >> + <feature name='jclouds-api-openstack-keystone' description='JClouds
>> >> - API - OpenStack Keystone' version='${project.version}' resolver='(obr)'>
>> >> <feature version='${project.version}'>jclouds</feature>
>> >>
>> >> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
>> >> </feature>
>> >>
>> >>
>> >
>
> --
> Andrew Gaul
> http://gaul.org/
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Posted by Andrew Gaul <ga...@apache.org>.
For @timuralp recent commit, I added his GitHub repo as a remote,
cherry-picked the branch, then pushed. This required a little more work
but I think contributors like seeing their names in the clouds.
On Fri, May 24, 2013 at 03:51:06PM -0700, Andrew Bayer wrote:
> Ideally, yes - but we need to document what the preferred procedure is for
> non-committer pull requests (which we should do, since we now have a wiki!)
> so I'm personally not particularly chuffed at this in the meantime.
>
> A.
>
> On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <ma...@apache.org>wrote:
>
> > Shouldn't the author be Tang Yong instead of Andrew Phillips?
> >
> >
> > On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
> >
> >> Updated Branches:
> >> refs/heads/1.6.x a67afcb21 -> a0232b09b
> >>
> >>
> >> JCLOUDS-68: Correcting Keystone feature description
> >> Submitted by Tang Yong
> >>
> >>
> >> Project:
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
> >> Commit:
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
> >> Tree:
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
> >> Diff:
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
> >>
> >> Branch: refs/heads/1.6.x
> >> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
> >> Parents: a67afcb
> >> Author: Andrew Phillips <an...@apache.org>
> >> Authored: Thu May 23 18:30:24 2013 +0200
> >> Committer: Andrew Phillips <an...@apache.org>
> >> Committed: Fri May 24 17:20:04 2013 -0400
> >>
> >> ----------------------------------------------------------------------
> >> feature/src/main/resources/feature.xml | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
> >> ----------------------------------------------------------------------
> >> diff --git a/feature/src/main/resources/feature.xml
> >> b/feature/src/main/resources/feature.xml
> >> index 4a29491..d32d340 100644
> >> --- a/feature/src/main/resources/feature.xml
> >> +++ b/feature/src/main/resources/feature.xml
> >> @@ -92,7 +92,7 @@ limitations under the License.
> >>
> >> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
> >> </feature>
> >>
> >> - <feature name='jclouds-api-openstack-keystone' description='JClouds
> >> - API - OpenStack Nova' version='${project.version}' resolver='(obr)'>
> >> + <feature name='jclouds-api-openstack-keystone' description='JClouds
> >> - API - OpenStack Keystone' version='${project.version}' resolver='(obr)'>
> >> <feature version='${project.version}'>jclouds</feature>
> >>
> >> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
> >> </feature>
> >>
> >>
> >
--
Andrew Gaul
http://gaul.org/
Re: git commit: JCLOUDS-68: Correcting Keystone feature description
Submitted by Tang Yong
Posted by Andrew Bayer <an...@gmail.com>.
Ideally, yes - but we need to document what the preferred procedure is for
non-committer pull requests (which we should do, since we now have a wiki!)
so I'm personally not particularly chuffed at this in the meantime.
A.
On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <ma...@apache.org>wrote:
> Shouldn't the author be Tang Yong instead of Andrew Phillips?
>
>
> On Fri, May 24, 2013 at 2:20 PM, <an...@apache.org> wrote:
>
>> Updated Branches:
>> refs/heads/1.6.x a67afcb21 -> a0232b09b
>>
>>
>> JCLOUDS-68: Correcting Keystone feature description
>> Submitted by Tang Yong
>>
>>
>> Project:
>> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09
>> Tree:
>> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09
>> Diff:
>> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09
>>
>> Branch: refs/heads/1.6.x
>> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a
>> Parents: a67afcb
>> Author: Andrew Phillips <an...@apache.org>
>> Authored: Thu May 23 18:30:24 2013 +0200
>> Committer: Andrew Phillips <an...@apache.org>
>> Committed: Fri May 24 17:20:04 2013 -0400
>>
>> ----------------------------------------------------------------------
>> feature/src/main/resources/feature.xml | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml
>> ----------------------------------------------------------------------
>> diff --git a/feature/src/main/resources/feature.xml
>> b/feature/src/main/resources/feature.xml
>> index 4a29491..d32d340 100644
>> --- a/feature/src/main/resources/feature.xml
>> +++ b/feature/src/main/resources/feature.xml
>> @@ -92,7 +92,7 @@ limitations under the License.
>>
>> <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle>
>> </feature>
>>
>> - <feature name='jclouds-api-openstack-keystone' description='JClouds
>> - API - OpenStack Nova' version='${project.version}' resolver='(obr)'>
>> + <feature name='jclouds-api-openstack-keystone' description='JClouds
>> - API - OpenStack Keystone' version='${project.version}' resolver='(obr)'>
>> <feature version='${project.version}'>jclouds</feature>
>>
>> <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle>
>> </feature>
>>
>>
>