[GitHub] [airflow] koroder commented on a diff in pull request #27145: Add support for a DAG display name different than dag_id

[GitBox <gi...@apache.org>]

koroder commented on code in PR #27145:
URL: https://github.com/apache/airflow/pull/27145#discussion_r1003216203


##########
airflow/models/dag.py:
##########
@@ -451,6 +453,7 @@ def __init__(
             max_active_tasks = concurrency
         self._max_active_tasks = max_active_tasks
         self._pickle_id: int | None = None
+        self._display_name = dag_id if display_name is None else display_name

Review Comment:
   @eladkal Most of the thought process I have taken from the discussion in https://github.com/apache/airflow/issues/22073 where the idea was to use a separate `display_name` supporting non-ascii characters for DAG/Tasks independently from `dag_id` and `task_id`. Directly using them in `dag_id`/`task_id` breaks couple of functionalities which I have referenced in the description. Let me know if we still need to go by a different approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org