You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/22 06:40:06 UTC
[GitHub] [arrow-rs] ritchie46 opened a new pull request #336: feature gate ipc reader/writer
ritchie46 opened a new pull request #336:
URL: https://github.com/apache/arrow-rs/pull/336
# Which issue does this PR close?
This closes #310. This was as easy as bumping `#[cfg(feature = "ipc")]` on the module. This make `flatbuffers` an optional dependency. To reduce migration friction, the feature `ipc` was added to the default features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #336: feature gate ipc reader/writer
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #336:
URL: https://github.com/apache/arrow-rs/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #336: feature gate ipc reader/writer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #336:
URL: https://github.com/apache/arrow-rs/pull/336#issuecomment-846365118
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#336](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cabcbb) into [master](https://codecov.io/gh/apache/arrow-rs/commit/71c21595a0856e4f87838c8c3bb5f2b04fb88024?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71c2159) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 82.53% 82.53%
=======================================
Files 162 162
Lines 44043 44043
=======================================
Hits 36350 36350
Misses 7693 7693
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71c2159...3cabcbb](https://codecov.io/gh/apache/arrow-rs/pull/336?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao commented on pull request #336: feature gate ipc reader/writer
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #336:
URL: https://github.com/apache/arrow-rs/pull/336#issuecomment-846367608
(note, the failure is unrelated; it seems that rust stopped being available on windows, still investigating why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org