You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/19 21:03:25 UTC
Review Request 71311: Added method to dump role tree state for
debugging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71311/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
It dumps the role tree state in JSON format. This can potentially
be added to an allocator debug endpoint.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
Diff: https://reviews.apache.org/r/71311/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71311: Added method to dump role tree state for
debugging.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71311/#review217300
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.hpp
Lines 216-217 (patched)
<https://reviews.apache.org/r/71311/#comment304593>
It would be nice if the signature indicated this has to do with json, perhaps something like:
```
void toJson(JSON::ObjectWriter* writer) const;
```
I think the reader will get this immediately without needing to read any comment or the implementation.
Returning JSON::Object also works, but is a lot more expensive unfortunately.
src/master/allocator/mesos/hierarchical.cpp
Lines 398 (patched)
<https://reviews.apache.org/r/71311/#comment304594>
Not including the "role"?
- Benjamin Mahler
On Aug. 19, 2019, 9:03 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71311/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 9:03 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It dumps the role tree state in JSON format. This can potentially
> be added to an allocator debug endpoint.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71311/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>