You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2018/11/26 18:58:56 UTC
[GitHub] spark pull request #23147: [SPARK-26140] followup: rename ShuffleMetricsRepo...
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/23147
[SPARK-26140] followup: rename ShuffleMetricsReporter
## What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/23105, due to working on two parallel PRs at once, I made the mistake of committing the copy of the PR that used the name ShuffleMetricsReporter for the interface, rather than the appropriate one ShuffleReadMetricsReporter. This patch fixes that.
## How was this patch tested?
This should be fine as long as compilation passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark ShuffleReadMetricsReporter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23147
----
commit 1d28d879572aa958b169acc5e1a48e52cced4c26
Author: Reynold Xin <rx...@...>
Date: 2018-11-26T18:56:18Z
ShuffleReadMetricsReporter
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23147
cc @gatorsmile @xuanyuanking
@cloud-fan I misunderstood your comment. Finally saw it today when I was looking at my other PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23147
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5367/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23147
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99284/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23147: [SPARK-26140] followup: rename ShuffleMetricsRepo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23147
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23147
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23147
**[Test build #99284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99284/testReport)** for PR 23147 at commit [`1d28d87`](https://github.com/apache/spark/commit/1d28d879572aa958b169acc5e1a48e52cced4c26).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23147
**[Test build #99284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99284/testReport)** for PR 23147 at commit [`1d28d87`](https://github.com/apache/spark/commit/1d28d879572aa958b169acc5e1a48e52cced4c26).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23147: [SPARK-26140] followup: rename ShuffleMetricsReporter
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23147
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org