You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/11 18:31:46 UTC
Review Request 61597: Windows: Fixed linking to `IPHlpAPI` library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler and Joseph Wu.
Bugs: MESOS-7704
https://issues.apache.org/jira/browse/MESOS-7704
Repository: mesos
Description
-------
While the `#pragma comment(lib...)` method works with MSVC, it is
inconsistent with how we link to the rest of the Windows libraries. So
it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
Furthermore, the `<iphlpapi.h>` header was removed from the individual
files and placed in `windows.hpp` to ensure it is included in the
correct order with respect to the other Windows headers.
Diffs
-----
3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
Diff: https://reviews.apache.org/r/61597/diff/1/
Testing
-------
stout-tests on Windows
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI`
library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182747
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review184461
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 11, 2017, 4:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182794
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182843
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182803
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182811
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182838
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182819
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182831
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182809
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182807
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 2:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 2:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182795
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182781
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182792
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182798
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 2:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 2:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182802
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182786
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182812
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182824
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182839
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182841
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 4:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182797
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182783
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182816
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182815
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182835
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182830
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182801
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182788
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 2:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 2:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182825
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182804
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182827
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182846
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182780
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182844
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182778
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182821
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182808
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182782
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182774
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182799
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182766
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182779
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182836
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182793
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182833
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182822
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 7:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 7:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182818
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182834
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 7:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 7:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182832
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182787
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 4:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182800
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182850
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182805
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182784
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Aug. 18, 2017, 9:29 a.m., Alexander Rukletsov wrote:
> > Ship It!
I've tested the chain up to this commit in my CMake setup (integration with Qt Creator + ccache) and confirm it works as expected (targets are set up properly, building and running tests works).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review183199
-----------------------------------------------------------
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review183199
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182823
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182820
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 12, 2017, 7:27 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 7:27 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182796
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 4:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182826
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182806
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:27 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/
-----------------------------------------------------------
(Updated Aug. 11, 2017, 4:27 p.m.)
Review request for mesos, Jeff Coffler and Joseph Wu.
Summary (updated)
-----------------
Fixed linking to `IPHlpAPI` library.
Bugs: MESOS-7704
https://issues.apache.org/jira/browse/MESOS-7704
Repository: mesos
Description
-------
While the `#pragma comment(lib...)` method works with MSVC, it is
inconsistent with how we link to the rest of the Windows libraries. So
it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
Furthermore, the `<iphlpapi.h>` header was removed from the individual
files and placed in `windows.hpp` to ensure it is included in the
correct order with respect to the other Windows headers.
Diffs
-----
3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
Diff: https://reviews.apache.org/r/61597/diff/1/
Testing
-------
stout-tests on Windows
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI`
library.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Aug. 11, 2017, 12:09 p.m., Mesos Reviewbot Windows wrote:
> > Bad review!
> >
> > Error:
> > No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
Weird, it had reviewers before it was posted.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182736
-----------------------------------------------------------
On Aug. 11, 2017, 11:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI`
library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182736
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 6:31 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 6:31 p.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI`
library.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Aug. 11, 2017, 2:45 p.m., Mesos Reviewbot Windows wrote:
> > Bad review!
> >
> > Error:
> > No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
Oh, I know why. There are some dependent reviews without a reviewer (as I used `support/post-reviews.py` which doesn't let you add reviewers when posting, and didn't particularly want to hand-edit 80+ reviews when Joe can find them all anyway).
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182749
-----------------------------------------------------------
On Aug. 11, 2017, 11:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61597: Windows: Fixed linking to `IPHlpAPI`
library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61597/#review182749
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 11, 2017, 11:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61597/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Jeff Coffler and Joseph Wu.
>
>
> Bugs: MESOS-7704
> https://issues.apache.org/jira/browse/MESOS-7704
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `#pragma comment(lib...)` method works with MSVC, it is
> inconsistent with how we link to the rest of the Windows libraries. So
> it was deleted and `IPHlpAPI` was added to stout's Windows dependencies.
>
> Furthermore, the `<iphlpapi.h>` header was removed from the individual
> files and placed in `windows.hpp` to ensure it is included in the
> correct order with respect to the other Windows headers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff
> 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624
> 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8
> 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd
> 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b
>
>
> Diff: https://reviews.apache.org/r/61597/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>