You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/07/13 01:52:49 UTC

[jira] Created: (ARIES-356) Make jndi proxy creation more flexible and, in the aries context, optional

Make jndi proxy creation more flexible and, in the aries context, optional
--------------------------------------------------------------------------

                 Key: ARIES-356
                 URL: https://issues.apache.org/jira/browse/ARIES-356
             Project: Aries
          Issue Type: Improvement
          Components: JNDI
    Affects Versions: 0.2
            Reporter: David Jencks
            Assignee: David Jencks
             Fix For: 0.2


There are a lot of cases when the current proxy creation fails, such as when a class is in the set of interfaces we're trying to proxy.  We should:

1.allow using cglib to proxy classes.
2. if the class can't be proxied, and a proxy is required (in the osgi: namespace) leave it out
3. (behavior up for debate) in the aries:services namespace, if there is a problem proxying, just return the raw service.

An example of when a service can't be proxied is it is a final class such as javax.mail.Session.

There's discussion on the dev list about what is appropriate for (3).  I'm committing my proposal to give us something concrete to discuss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (ARIES-356) Make jndi proxy creation more flexible and, in the aries context, optional

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reopened ARIES-356:
-------------------------------

      Assignee: Jarek Gawor  (was: David Jencks)

The class proxying with cglib can lead to java.lang.ClassNotFoundException: net.sf.cglib.proxy.Callback errors. Looks like the classloader that is used to create the proxy needs to also be able to load cglib classes.


> Make jndi proxy creation more flexible and, in the aries context, optional
> --------------------------------------------------------------------------
>
>                 Key: ARIES-356
>                 URL: https://issues.apache.org/jira/browse/ARIES-356
>             Project: Aries
>          Issue Type: Improvement
>          Components: JNDI
>    Affects Versions: 0.2
>            Reporter: David Jencks
>            Assignee: Jarek Gawor
>             Fix For: 0.2
>
>
> There are a lot of cases when the current proxy creation fails, such as when a class is in the set of interfaces we're trying to proxy.  We should:
> 1.allow using cglib to proxy classes.
> 2. if the class can't be proxied, and a proxy is required (in the osgi: namespace) leave it out
> 3. (behavior up for debate) in the aries:services namespace, if there is a problem proxying, just return the raw service.
> An example of when a service can't be proxied is it is a final class such as javax.mail.Session.
> There's discussion on the dev list about what is appropriate for (3).  I'm committing my proposal to give us something concrete to discuss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ARIES-356) Make jndi proxy creation more flexible and, in the aries context, optional

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved ARIES-356.
-------------------------------

    Resolution: Fixed

In revision 979336 I refactored the jdk/cglib proxy code into separate classes and made sure the classloader used for cglib proxies can load cglib classes.


> Make jndi proxy creation more flexible and, in the aries context, optional
> --------------------------------------------------------------------------
>
>                 Key: ARIES-356
>                 URL: https://issues.apache.org/jira/browse/ARIES-356
>             Project: Aries
>          Issue Type: Improvement
>          Components: JNDI
>    Affects Versions: 0.2
>            Reporter: David Jencks
>            Assignee: Jarek Gawor
>             Fix For: 0.2
>
>
> There are a lot of cases when the current proxy creation fails, such as when a class is in the set of interfaces we're trying to proxy.  We should:
> 1.allow using cglib to proxy classes.
> 2. if the class can't be proxied, and a proxy is required (in the osgi: namespace) leave it out
> 3. (behavior up for debate) in the aries:services namespace, if there is a problem proxying, just return the raw service.
> An example of when a service can't be proxied is it is a final class such as javax.mail.Session.
> There's discussion on the dev list about what is appropriate for (3).  I'm committing my proposal to give us something concrete to discuss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ARIES-356) Make jndi proxy creation more flexible and, in the aries context, optional

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved ARIES-356.
-------------------------------

    Resolution: Fixed

Per discussions I updated the code so that lookups via the "aries:services/" scheme will always return a raw (non-proxied) services. Committed in revision 965942.


> Make jndi proxy creation more flexible and, in the aries context, optional
> --------------------------------------------------------------------------
>
>                 Key: ARIES-356
>                 URL: https://issues.apache.org/jira/browse/ARIES-356
>             Project: Aries
>          Issue Type: Improvement
>          Components: JNDI
>    Affects Versions: 0.2
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 0.2
>
>
> There are a lot of cases when the current proxy creation fails, such as when a class is in the set of interfaces we're trying to proxy.  We should:
> 1.allow using cglib to proxy classes.
> 2. if the class can't be proxied, and a proxy is required (in the osgi: namespace) leave it out
> 3. (behavior up for debate) in the aries:services namespace, if there is a problem proxying, just return the raw service.
> An example of when a service can't be proxied is it is a final class such as javax.mail.Session.
> There's discussion on the dev list about what is appropriate for (3).  I'm committing my proposal to give us something concrete to discuss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.