You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Greg Bowyer (Created) (JIRA)" <ji...@apache.org> on 2012/03/25 01:28:25 UTC
[jira] [Created] (SOLR-3271) ShardHandlerFactory really could be an
interface
ShardHandlerFactory really could be an interface
------------------------------------------------
Key: SOLR-3271
URL: https://issues.apache.org/jira/browse/SOLR-3271
Project: Solr
Issue Type: Improvement
Affects Versions: 3.6, 4.0
Reporter: Greg Bowyer
Priority: Trivial
While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: SOLR-3271.patch
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Priority: Minor (was: Trivial)
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Minor
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: (was: SOLR-3271.patch)
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: SOLR-3271.patch
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3271) ShardHandlerFactory really could be
an interface
Posted by "Greg Bowyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241837#comment-13241837 ]
Greg Bowyer commented on SOLR-3271:
-----------------------------------
It came up during my current project of insanity whereby I was trying to get solr to run in hadoop (not ontop of like katta but within)
It doesnt matter that much either way, but it made the code slightly easier to hack on
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Minor
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: SOLR-3271.patch
... Same thing, but also makes ShardHandler an interface too
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: SOLR-3271.patch
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3271) ShardHandlerFactory really could be
an interface
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241603#comment-13241603 ]
Ryan McKinley commented on SOLR-3271:
-------------------------------------
Is there a real advantage to have this as an interface? (i mean besides good design :)
The problem with interfaces and a strong back-compatible policy. With an abstract class, we can at least add default behavior without breaking compatibility in the future.
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Minor
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3271) ShardHandlerFactory really could be an
interface
Posted by "Greg Bowyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated SOLR-3271:
------------------------------
Attachment: (was: SOLR-3271.patch)
> ShardHandlerFactory really could be an interface
> ------------------------------------------------
>
> Key: SOLR-3271
> URL: https://issues.apache.org/jira/browse/SOLR-3271
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6, 4.0
> Reporter: Greg Bowyer
> Priority: Trivial
> Labels: distributed, shard
> Attachments: SOLR-3271.patch, SOLR-3271.patch
>
>
> While I was browsing the code and playing about with a silly idea I had that messes with the distributed search from the perspective of the ShardHandlerFactory I noticed that the code makes the ShardHandlerFactory a "pure virtual" class.
> I wonder if it could just be an interface instead ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org