You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/05 19:59:31 UTC
[GitHub] [superset] graceguo-supercat opened a new issue #12285: [Explore] Timepicker converts date range type
graceguo-supercat opened a new issue #12285:
URL: https://github.com/apache/superset/issues/12285
#### How to reproduce the bug
1. Go to Explore view, from date picker, choose `Range Type`: Last => choose Last week
2. see `Time Range` display as `2020-12-29 <= col < 2021-01-05`
3. The time range is correct, but it is user chose option: Last week
4. The reason that we offered `Last` or `Previous`, these human readable time range is easier for user to get what the time range is. If user pick these Range Type, we should display as it. If user pick from custom type and pick same date, we should display the date.
#### Screenshots
### Environment
latest master
cc @junlincc @zhaoyongjie @zuzana-vej
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-754923315
yes, display `Last week` is old behavior. Even for the old date picker, you can pick "Last week" as option, and then we display "Last week" in the time range pill (as shown in screenshot).
when i run some old charts from latest master branch, all the "Last week" are displayed as actual date. I think this change is not necessary, will cause some confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12285: [Explore] Timepicker converts date range type
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-754887098
we display the actual time range on the pill as a validation. if that's compromising UX, we are happy to switch it back for `last` and `previous`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-757135474
Confirming all known issues around Explore Timepicker are resolved in latest master 01/09/2021 @ 11:27am (UTC)
will implement tooltip for Advanced Time Range and new feature - customize timezone in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-757135474
Confirming all known issues around Explore Timepicker are resolved in latest master 01/09/2021 @ 11:27am (UTC)
will implement tooltip for Advanced Time Range and new feature - customize timezone in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-757135474
Confirming all known issues around Explore Timepicker are resolved in latest master
will implement tooltip for Advanced Time Range and new feature - customize timezone in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12285:
URL: https://github.com/apache/superset/issues/12285#issuecomment-757135474
Confirming all known issues around Explore Timepicker are resolved in latest master
will implement tooltip for Advanced Time Range and new feature - customize timezone in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #12285: [Explore] Timepicker converts date range type on pill
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed issue #12285:
URL: https://github.com/apache/superset/issues/12285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org