You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Spenserrrr (via GitHub)" <gi...@apache.org> on 2026/09/16 18:36:29 UTC
[PR] [SPARK-59271][PYTHON][TEST][FOLLOWUP] Fix pandas.api.types golden test with NumPy 1.23 [spark]
Spenserrrr opened a new pull request, #58869:
URL: https://github.com/apache/spark/pull/58869
### What changes were proposed in this pull request?
This PR adds a NumPy-version override for the input-type cell in the pandas.api.types object-predicate golden test.
### Why are the changes needed?
Spark's minimum dependency profile uses NumPy 1.23.2, where `type(np.dtype("int64")).__name__` is `dtype[int64]` rather than `Int64DType`. Without the override, the scheduled minimum-dependency build fails although the predicate results are unchanged.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The focused test passed with NumPy 1.23.2, 1.24.4, 1.25.0, and 2.4.1; the scheduled minimum-dependency run demonstrates the failure without the override.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59271][PYTHON][TEST][FOLLOWUP] Fix pandas.api.types golden test with NumPy 1.23 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58869:
URL: https://github.com/apache/spark/pull/58869#issuecomment-5726381272
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/9459e6c4ef7725999db3e048144926763306f211
- merged into branch-4.x https://github.com/apache/spark/commit/3bb159ebcdd7b57f78d20d9b419e2e577a859ba8
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59271][PYTHON][TEST][FOLLOWUP] Fix pandas.api.types golden test with NumPy 1.23 [spark]
Posted by "Spenserrrr (via GitHub)" <gi...@apache.org>.
Spenserrrr commented on PR #58869:
URL: https://github.com/apache/spark/pull/58869#issuecomment-5703914128
Hi @gaogaotiantian! This is a small follow-up to #58537, fixing its minimum-dependency CI failure on NumPy 1.23.2. Could you take a look when you have time? Thanks!
cc @Yicong-Huang @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59271][PYTHON][TEST][FOLLOWUP] Fix pandas.api.types golden test with NumPy 1.23 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #58869: [SPARK-59271][PYTHON][TEST][FOLLOWUP] Fix pandas.api.types golden test with NumPy 1.23
URL: https://github.com/apache/spark/pull/58869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org