You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/11 06:48:09 UTC

[GitHub] [ozone] adoroszlai commented on pull request #1685: HDDS-4552. Read data from chunk into ByteBuffer[] instead of single ByteBuffer.

adoroszlai commented on pull request #1685:
URL: https://github.com/apache/ozone/pull/1685#issuecomment-796504948


   > ByteString concat could work. But the problem is ChunkBuffer wraps around ByteBuffers. And checksums are calculated on ChunkBuffers. We would have to change the whole ChunkBuffer model (or change Checksum computations to use ByteStrings instead).
   
   Just an idea: we have a `ChunkBuffer` implementation which wraps a list of `ByteBuffer`s, and `ByteString#asReadOnlyByteBufferList` provides exactly that list.  I'm not sure it fully addresses all your needs.
   
   > Also, are there any acceptance tests for new clients talking to old servers?
   
   Yes, the same `xcompat` tests this situation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org