You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <lu...@softhome.net> on 2004/05/12 17:31:26 UTC
Re: [PATCH] svn_cmdline_printf and friends, take 3
On Wed, 12 May 2004, Nicolás Lichtmaier wrote:
>
> >+svn_error_t *svn_cmdline_printf (apr_pool_t *pool,
> >+ const char *fmt,
> >+ ...);
> >
> >
>
> By using "printf" subversion has been taking advantage of a GCC feature:
> to report error in format strings. This is a very good thing, as thee
Updated my patch with __attribute__ declarations for GCC, relying on APR
to define it to nothing on other compilers.
//P
Re: [PATCH] svn_cmdline_printf and friends, take 3
Posted by "Peter N. Lundblad" <lu...@softhome.net>.
Hi,
On Wed, 12 May 2004, [UTF-8] Branko �^Libej wrote:
> Peter N. Lundblad wrote:
>
> Looks good. +1.
>
r9704. Thanks..
> And now for the big one, actually using these in the code... :-)
>
I'll do this in parts, since, as you say, it will be huge...
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svn_cmdline_printf and friends, take 3
Posted by Branko Čibej <br...@xbc.nu>.
Peter N. Lundblad wrote:
>On Wed, 12 May 2004, Nicolás Lichtmaier wrote:
>
>
>
>>>+svn_error_t *svn_cmdline_printf (apr_pool_t *pool,
>>>+ const char *fmt,
>>>+ ...);
>>>
>>>
>>>
>>>
>>By using "printf" subversion has been taking advantage of a GCC feature:
>>to report error in format strings. This is a very good thing, as thee
>>
>>
>
>Updated my patch with __attribute__ declarations for GCC, relying on APR
>to define it to nothing on other compilers.
>
>
Looks good. +1.
And now for the big one, actually using these in the code... :-)
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org