You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/03/23 14:18:05 UTC

[PR] HDDS-14885. Replace usage of Hadoop ...TestUtils [ozone]

adoroszlai opened a new pull request, #9966:
URL: https://github.com/apache/ozone/pull/9966

   ## What changes were proposed in this pull request?
   
   Replace usage of Hadoop's test utils (only affects contract tests) with regular assertions and Ozone's `GenericTestUtils`.
   
   Remove exclusion of contract tests for banned imports.
   
   https://issues.apache.org/jira/browse/HDDS-14885
   
   ## How was this patch tested?
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/23438883833/job/68188446350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14885. Replace usage of Hadoop ...TestUtils [ozone]

Posted by "yandrey321 (via GitHub)" <gi...@apache.org>.
yandrey321 commented on code in PR #9966:
URL: https://github.com/apache/ozone/pull/9966#discussion_r2977633484


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractMultipartUploaderTest.java:
##########
@@ -830,11 +834,8 @@ public void testConcurrentUploads() throws Throwable {
     // consistent.
     final int consistencyDelay = timeToBecomeConsistentMillis();
     if (consistencyDelay > 0) {
-      eventually(consistencyDelay,
-          () -> verifyFileLength(file, size2),
-          new LambdaTestUtils.ProportionalRetryInterval(
-              CONSISTENCY_INTERVAL,
-              consistencyDelay));
+      GenericTestUtils.waitFor(() -> verifyFileLength(file, size2),

Review Comment:
   max wait time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14885. Replace usage of Hadoop ...TestUtils [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9966:
URL: https://github.com/apache/ozone/pull/9966


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14885. Replace usage of Hadoop ...TestUtils [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9966:
URL: https://github.com/apache/ozone/pull/9966#discussion_r2979156535


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractMultipartUploaderTest.java:
##########
@@ -830,11 +834,8 @@ public void testConcurrentUploads() throws Throwable {
     // consistent.
     final int consistencyDelay = timeToBecomeConsistentMillis();
     if (consistencyDelay > 0) {
-      eventually(consistencyDelay,
-          () -> verifyFileLength(file, size2),
-          new LambdaTestUtils.ProportionalRetryInterval(
-              CONSISTENCY_INTERVAL,
-              consistencyDelay));
+      GenericTestUtils.waitFor(() -> verifyFileLength(file, size2),

Review Comment:
   `consistencyDelay`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14885. Replace usage of Hadoop ...TestUtils [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9966:
URL: https://github.com/apache/ozone/pull/9966#issuecomment-4117573170

   Thanks @spacemonkd, @yandrey321 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org