You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/11/05 07:19:38 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3783:
add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3779
wu-sheng commented on a change in pull request #3783: add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3779
URL: https://github.com/apache/skywalking/pull/3783#discussion_r342409675
##########
File path: test/plugin/scenarios/apm-toolkit-trace-scenario/src/main/java/test/org/apache/skywalking/apm/testcase/toolkit/controller/TestController.java
##########
@@ -62,6 +62,14 @@ public String toolKitCase() {
// ignore
}
});
+ testService.asyncSupplier(()->{
+ try {
+ visit("http://localhost:8080/apm-toolkit-trace-scenario/case/asyncVisit/runnable");
+ } catch (IOException e) {
Review comment:
@sxzaihua You should add your own servlet method(`supplier`), and follow the plugin test doc, to add your new segment to verify the plugin feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services