You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/30 22:52:35 UTC
[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15605
to look at the new patch set (#2).
Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace
......................................................................
KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace
A TSAN build yielded a stack trace like:
@ 0x444a88 __tsan::ProcessPendingSignals()
@ 0x4541c1 __interceptor_pthread_mutex_trylock
@ 0x7fbca26124e1 kudu::Mutex::TryAcquire()
@ 0x7fbca2612893 kudu::Mutex::Acquire()
@ 0x4fe036 kudu::MutexLock::MutexLock()
@ 0x504abd kudu::CountDownLatch::WaitUntil()
@ 0x504a5f kudu::CountDownLatch::WaitFor()
@ 0x4f04a9 kudu::(anonymous namespace)::SleeperThread()
...
Rather than find the synchronization primitive frame least likely to be
inlined, let's take a more comprehensive approach and search for multiple
candidate frames, including SleeperThread.
I tested this locally in DEBUG, RELEASE, ASAN, and TSAN modes.
Change-Id: Ia4ca0f48ba1d7ad4cea40b70af271d7948f78a57
---
M src/kudu/util/debug-util-test.cc
1 file changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/15605/2
--
To view, visit http://gerrit.cloudera.org:8080/15605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4ca0f48ba1d7ad4cea40b70af271d7948f78a57
Gerrit-Change-Number: 15605
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)