You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/10/20 16:14:49 UTC
[GitHub] trafficserver pull request #1128: Doc: tweaks and cleanup
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1128
Doc: tweaks and cleanup
Just getting annoyed at the range of errors in the documentation build so cleaning up a few. The version tweaking clears up over 400+ errors for me, so I definitely like that. I am also trying to clear out all the cluster documentation as AFAIK there is no clustering anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver doc-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1128
----
commit b543dcb55352a1a3300f9208fc406f0cf190d190
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-10-20T16:11:27Z
Doc: tweaks and cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1060/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1128
I'm a bit at a loss about what to do with enums. For some bizarre reason the C++ domain has enum support but C doesn't. The choices are
* Use C 'type' and 'var'
* Use C 'type' and 'member'
* Use C++ 'enum' and 'enumerator'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1063/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/953/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/955/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1061/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/952/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1128
@jsime Can you review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by jsime <gi...@git.apache.org>.
Github user jsime commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Sorry it took a couple days to review, but everything non-enum related looks good. Thanks for all the cleanup, @SolidWallOfCode!
The lack of proper enum support in the C sphinx domain is bothersome. I'd be inclined to either abuse the C++ domain's enum support even for C code, or take the longer view of trying to port (or encourage someone to port) the enumerator from the C++ domain to the C domain in Sphinx. The latter would involve us bumping Sphinx versions, but at least it would feel less wrong than using the wrong Sphinx domain for parts of the TS C API docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1128: Doc: tweaks and cleanup
Posted by jsime <gi...@git.apache.org>.
Github user jsime closed the pull request at:
https://github.com/apache/trafficserver/pull/1128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/951/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1128
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1059/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Posted by jsime <gi...@git.apache.org>.
Github user jsime commented on the issue:
https://github.com/apache/trafficserver/pull/1128
Ah, no, sorry - this does look good as-is and I'm going to merge here momentarily. I was more thinking aloud about a somewhat longer-term approach to the enum issue (since we don't have an ideal solution with the current domains in Sphinx). But that shouldn't hold this PR up, since there's lots of other great cleanup in here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---