[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1486: feat: support secret plugin config

[GitBox <gi...@apache.org>]

tao12345666333 commented on code in PR #1486:
URL: https://github.com/apache/apisix-ingress-controller/pull/1486#discussion_r1039082058


##########
pkg/kube/apisix/apis/config/v2beta3/types.go:
##########
@@ -161,6 +161,8 @@ type ApisixRouteHTTPPlugin struct {
 	Enable bool `json:"enable" yaml:"enable"`
 	// Plugin configuration.
 	Config ApisixRouteHTTPPluginConfig `json:"config" yaml:"config"`
+	// Plugin configuration secretRef.
+	SecretConfig string `json:"secretConfig" yaml:"secretConfig"`

Review Comment:
   v2beta3 is deprecated, we don't need to modify it anymore.



##########
pkg/kube/apisix/apis/config/v2/types.go:
##########
@@ -170,6 +170,8 @@ type ApisixRoutePlugin struct {
 	Enable bool `json:"enable" yaml:"enable"`
 	// Plugin configuration.
 	Config ApisixRoutePluginConfig `json:"config" yaml:"config"`
+	// Plugin configuration secretRef.
+	SecretConfig string `json:"secretConfig" yaml:"secretConfig"`

Review Comment:
   I prefer it called SecretRef. The semantics are clearer, this is a reference to the secret



##########
pkg/kube/apisix/apis/config/v2/types.go:
##########
@@ -170,6 +170,8 @@ type ApisixRoutePlugin struct {
 	Enable bool `json:"enable" yaml:"enable"`
 	// Plugin configuration.
 	Config ApisixRoutePluginConfig `json:"config" yaml:"config"`
+	// Plugin configuration secretRef.
+	SecretConfig string `json:"secretConfig" yaml:"secretConfig"`

Review Comment:
   It can be left unset, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org