You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/24 08:28:20 UTC

[GitHub] [pulsar] shibd opened a new issue #13488: [PIP-128] Add new command STOP_XXX

shibd opened a new issue #13488:
URL: https://github.com/apache/pulsar/issues/13488


   ## Motivation
   
   Broker send `CLOSE_PRODUCER/CLOSE_CONSUMER` to client when delete topic, But client will be reconnect. If config `allowAutoTopicCreation=true` will trigger create topic again.
   
   https://github.com/apache/pulsar/blob/9f599c9572e5d9b1f15efa6e895e7eb29b284e57/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java#L130-L133
   
   ## Goal
   
   Add new commands `STOP_PRODUCER/STOP_CONSUMER`, When the client receives the command, it only closes without reconnecting.
   
   ## API Changes
   
   1. Add command to `BaseCommand`
   ```java
   message BaseCommand {
       enum Type {
       // ...
       STOP_PRODUCER = 64;
       STOP_CONSUMER = 65
       }
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] shibd edited a comment on issue #13488: [PIP-128] Add new command STOP_PRODUCER and STOP_CONSUMER

Posted by GitBox <gi...@apache.org>.
shibd edited a comment on issue #13488:
URL: https://github.com/apache/pulsar/issues/13488#issuecomment-1000723460


   @codelipenghui @hangc0276 @MaiCw4J @Technoboy-  PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] shibd commented on issue #13488: [PIP-128] Add new command STOP_PRODUCER and STOP_CONSUMER

Posted by GitBox <gi...@apache.org>.
shibd commented on issue #13488:
URL: https://github.com/apache/pulsar/issues/13488#issuecomment-1000723460


   @hangc0276 @MaiCw4J @Technoboy-  PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] shibd closed issue #13488: [PIP-128] Add new command STOP_PRODUCER and STOP_CONSUMER

Posted by GitBox <gi...@apache.org>.
shibd closed issue #13488:
URL: https://github.com/apache/pulsar/issues/13488


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] shibd commented on issue #13488: [PIP-128] Add new command STOP_PRODUCER and STOP_CONSUMER

Posted by GitBox <gi...@apache.org>.
shibd commented on issue #13488:
URL: https://github.com/apache/pulsar/issues/13488#issuecomment-1002571144


   > Usually, we will not force to close the producer and consumer at the
   server-side,
   because we don't if the client-side can handle this case well.
   Or, if the topic will retire, and you don't want the clients to connect to
   it, you can just terminate the topic.
   --- author @codelipenghui 
   
   Thanks reply, `terminate the topic` is useful


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org