You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ap...@apache.org on 2018/11/19 23:53:38 UTC
[incubator-pinot] branch master updated: [TE] rootcause - prevent
line-break of exclude/hide links in filter selector (#3519)
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6581245 [TE] rootcause - prevent line-break of exclude/hide links in filter selector (#3519)
6581245 is described below
commit 6581245ba48aaac97b0774e2e470c4c10090649b
Author: Alexander Pucher <ap...@linkedin.com>
AuthorDate: Mon Nov 19 15:53:33 2018 -0800
[TE] rootcause - prevent line-break of exclude/hide links in filter selector (#3519)
---
.../rootcause-select-metric-dimension/template.hbs | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
index 7fa3e36..c155cce 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
@@ -21,17 +21,15 @@
<div class="{{if showExclusions 'col-xs-3' 'col-xs-6'}}">
<label class="te-label te-label--small" for="select-filters">
Filter by
+ {{#unless showExclusions}}
+ <a {{action "showExclusions"}}>Exclude</a>
+ {{/unless}}
<span>
<i class="glyphicon glyphicon-question-sign"></i>
{{#tooltip-on-element class="te-tooltip"}}
You can add filters to the analyzed metric, for example page views for "countryCode::us" only. The available filters depend on the data set. You can also add filters via left-click in the "Dimensions" tab.
{{/tooltip-on-element}}
</span>
- {{#unless showExclusions}}
- <span>
- <a {{action "showExclusions"}}>Exclude</a>
- </span>
- {{/unless}}
</label>
{{filter-select
@@ -50,17 +48,15 @@
{{partial 'partials/rootcause/exclusion-warning'}}
{{/if}}
Exclude
+ {{#unless hasExclusions}}
+ <a {{action "hideExclusions"}}>Hide</a>
+ {{/unless}}
<span>
<i class="glyphicon glyphicon-question-sign"></i>
{{#tooltip-on-element class="te-tooltip"}}
You can exclude subsets of the analyzed metric, for example all page views without "countryCode::us". The available exclusions depend on the data set. You can also add exclusions via right-click in the "Dimensions" tab.
{{/tooltip-on-element}}
- </span>
- {{#unless hasExclusions}}
- <span>
- <a {{action "hideExclusions"}}>Hide</a>
- </span>
- {{/unless}}
+ </span>
</label>
{{filter-select
selected=exclusions
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org