You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2022/05/02 17:30:00 UTC
[jira] [Commented] (CASSANDRA-17593) StorageService read threshold get methods throw NullPointerException due to not handling null configs
[ https://issues.apache.org/jira/browse/CASSANDRA-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530859#comment-17530859 ]
David Capwell commented on CASSANDRA-17593:
-------------------------------------------
it would be good to have a test which generically catches this as I feel this wouldn't be the only place impacted.
> StorageService read threshold get methods throw NullPointerException due to not handling null configs
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17593
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.1
>
>
> org.apache.cassandra.service.StorageService#getCoordinatorLargeReadWarnThreshold and other similar get methods touch the following null configs
> {code}
> public volatile DataStorageSpec coordinator_read_size_warn_threshold = null;
> public volatile DataStorageSpec coordinator_read_size_fail_threshold = null;
> public volatile DataStorageSpec local_read_size_warn_threshold = null;
> public volatile DataStorageSpec local_read_size_fail_threshold = null;
> public volatile DataStorageSpec row_index_read_size_warn_threshold = null;
> public volatile DataStorageSpec row_index_read_size_fail_threshold = null
> {code}
> Null is a valid state for these configs, so null must be handled in the get methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org