You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/09 01:09:33 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24335: chore: remove deprecated api /superset/filter/...
dpgaspar opened a new pull request, #24335:
URL: https://github.com/apache/superset/pull/24335
### SUMMARY
Removes old deprecated API `/superset/filter/<datasource_type>/<int:datasource_id>/<column>/` use `/api/v1/datasource/<datasource_type>/<datasource_id>/column/<column_name>/values/` instead
First PR on the effort on removing deprecated API from `/superset`: https://github.com/apache/superset/discussions/24332
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24335: chore: remove deprecated api /superset/filter/...
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24335:
URL: https://github.com/apache/superset/pull/24335#discussion_r1224598467
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [---](https://github.com/apache/superset/pull/---): Removed deprecated API `/superset/filter/<datasource_type>/<int:datasource_id>/<column>/`
Review Comment:
Could you move this to the Breaking Changes section and add the PR number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24335: chore: remove deprecated api /superset/filter/...
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24335:
URL: https://github.com/apache/superset/pull/24335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24335: chore: remove deprecated api /superset/filter/...
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24335:
URL: https://github.com/apache/superset/pull/24335#issuecomment-1583781354
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24335](https://app.codecov.io/gh/apache/superset/pull/24335?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (09cf1e7) into [master](https://app.codecov.io/gh/apache/superset/commit/af8f7253e161eae593934506c57d96333627d0fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (af8f725) will **decrease** coverage by `11.26%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 09cf1e7 differs from pull request most recent head 39d3a03. Consider uploading reports for the commit 39d3a03 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24335 +/- ##
===========================================
- Coverage 69.08% 57.82% -11.26%
===========================================
Files 1905 1905
Lines 74849 74835 -14
Branches 8108 8108
===========================================
- Hits 51706 43273 -8433
- Misses 21031 29450 +8419
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.59% <ø> (+<0.01%)` | :arrow_up: |
| python | `60.14% <ø> (-23.13%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.08% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `36.33% <ø> (-38.95%)` | :arrow_down: |
... and [302 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org