You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Afremov (JIRA)" <ji...@apache.org> on 2008/03/20 11:21:24 UTC
[jira] Created: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
[drlvm] Remove unsupported runtime helpers.
-------------------------------------------
Key: HARMONY-5621
URL: https://issues.apache.org/jira/browse/HARMONY-5621
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Pavel Afremov
Remove unsupported runtime helpers.
Following runtime helpers are removed:
VM_RT_F2I
VM_RT_F2L
VM_RT_D2I
VM_RT_D2L
VM_RT_FREM
VM_RT_DREM
VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580763#action_12580763 ]
Alexey Varlamov commented on HARMONY-5621:
------------------------------------------
BTW, do we have any tests covering the type conversions - all those corner cases etc? Would be nice to get a regression test here.
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-5621.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Pavel, I integrated the patch at revision: 644289, with minor enhancements:
removed charArrayCopy support everythere, dropped 2 files which became bogus.
I still hope to get regression tests from you ;)
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Fix For: 5.0M6
>
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5621:
-----------------------------------
Attachment: remove_unsuported_runtime_helpers_1.patch
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581027#action_12581027 ]
Alexey Varlamov commented on HARMONY-5621:
------------------------------------------
Notes on the patch:
1) It makes sense to declare consts like MIN_INT/MIN_LONG and use them consistently;
2) Better to eliminate CHAR_ARRAYCOPY optimization at all instead of keeping temporary helper on IPF. That is, Java translator should be fixed: see JavaByteCodeTranslator::invokestatic() and JavaByteCodeTranslator::genCharArrayCopy().
BTW, there is a related HARMONY-3584, I'll look if we can merge these issues.
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5621:
-----------------------------------
Attachment: (was: remove_extra_exceptions_helper_2.patch)
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Fix For: 5.0M6
>
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-5621:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Attachments: remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5621) [drlvm] Remove unsupported runtime
helpers.
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Afremov updated HARMONY-5621:
-----------------------------------
Attachment: remove_extra_exceptions_helper_2.patch
Patch should be rebased and tested on all platforms.
> [drlvm] Remove unsupported runtime helpers.
> -------------------------------------------
>
> Key: HARMONY-5621
> URL: https://issues.apache.org/jira/browse/HARMONY-5621
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Pavel Afremov
> Assignee: Alexey Varlamov
> Fix For: 5.0M6
>
> Attachments: remove_extra_exceptions_helper_2.patch, remove_unsuported_runtime_helpers_1.patch
>
>
> Remove unsupported runtime helpers.
> Following runtime helpers are removed:
> VM_RT_F2I
> VM_RT_F2L
> VM_RT_D2I
> VM_RT_D2L
> VM_RT_FREM
> VM_RT_DREM
> VM_RT_CHAR_ARRAYCOPY_NO_EXC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.