You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/12/22 10:43:03 UTC
[GitHub] incubator-zeppelin pull request: Bug fix/table scrolling and hidin...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/565
Bug fix/table scrolling and hiding
### What is this PR for?
For Table, reimplemented, scrolling, deleting a bug in the Table Header, Scrolling area expressed bugs have been fixed.
### What type of PR is it?
Bug Fix
### Todos
- [x] \(Re-modification\) always top fixed column title for table
- [x] table scrolling bug fixed. out of area scroll
https://github.com/apache/incubator-zeppelin/pull/556
- [x] After the re-run, remove the scroll bar
- [x] License Infomation
- [x] record the license information of jquery.floatThead.
- [x] Browser Test
- [x] Safari (9.0.2(11601.3.9)
- [x] Firefox (43.0)
- [x] Chrome (47.0.2526.106 (64-bit)
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-523
### How should this be tested?
Step 1. create table on zeppelin
example query)
``` python
%pyspark
TABLE = "%table Header1\tHeader2\n"
for x in range(1,51):
#TABLE += "scroll";
TABLE += str(x);
if (x%2) == 0:
TABLE += "\n"
else:
TABLE += "\t"
z.put("table_context", TABLE)
```
``` scala
println(z.get("table_context"))
```
Step 2.
Scroll the mouse over the Table.
Step 3.
re Run Paragraph.
Step 4.
Scroll the mouse over the Table.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
You are using an external source?
\- I used jquery.floatThead (MIT) Libraries.
It helps to secure the Table Header.
Why did this problem occur?
\- ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect scrollbar library.
height calculation miss.
Why it has created a new PR?
\- A problem with a private Git Repository to my mistakes.
Please previous PR, see the following URL.
https://github.com/apache/incubator-zeppelin/pull/556
In the ScreenShot, it seems to have changed color table. What changed things?
\- no. It's Animated Gif color problems.
Changes that do not exist.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin bug_fix/table_scrolling_and_hiding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
commit bf16e1aa108dd565b41c372d24ddd8ee1ab3a128
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-22T08:45:40Z
bug fixed visualize table component
commit f8123c54b16db63857764f83eed57e7c44caeb5a
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-22T09:01:02Z
Fixed scrollbar when the first Mouseover does not appear in the Table.
commit ba165bf42ec493c12863c057523acf2d02c69c67
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-22T09:08:56Z
variable name change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-168508379
LGTM and merge into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167262195
@corneadoug Sure, please take a look closer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167033600
Additional modifications
according to a floating Thead, Paragraph Option Fixes a problem.
#### before
<img width="399" alt="before" src="https://cloud.githubusercontent.com/assets/10525473/11988660/2d0e09d2-a9a8-11e5-8f00-3a89b15b2107.png">
#### after
<img width="325" alt="after" src="https://cloud.githubusercontent.com/assets/10525473/11988659/2d0d60a4-a9a8-11e5-85eb-baf9877ffa02.png">
This bug fixes to the table was completed.
I would like to discuss and review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-168356608
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167169284
Looks good to me.
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167945766
@corneadoug
I have completed bug fixes.
Thank you for feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by mkoryak <gi...@git.apache.org>.
Github user mkoryak commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167914278
author of floatThead here. let me know if i can be of assistance (without installing anything). :cat2:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167918565
@corneadoug
Thank you good feedback.
I will review that section again as your opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167236262
@Leemoonsoo
I'd like to take a closer look, especially since it's adding a new library
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167258598
I'm sympathetic to your comments.
Note that I am so attached to a cord and library link.
I hope this helps to determine.
https://github.com/noraesae/perfect-scrollbar/issues/273
https://github.com/noraesae/perfect-scrollbar/issues/256
http://mkoryak.github.io/floatThead/examples/perfect-scrollbar/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-523 ] Table Header fixed...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/565#issuecomment-167918286
I tried it after rebasing with master (because of the resize that was just merged).
Everything seems to work fine, however I found a bug when we switch from table to graph:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---