You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/08/25 10:53:09 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #5223: Fix #5212 to add XA test for IBMMQ client
zhfeng opened a new pull request, #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223
Fix #5212 and it need to work with the fix of
- https://github.com/quarkiverse/quarkus-pooled-jms/pull/152
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#discussion_r1308683308
##########
integration-tests/messaging/jms/src/main/java/org/apache/camel/quarkus/messaging/jms/JmsRoutes.java:
##########
@@ -44,11 +47,13 @@ public void configure() throws Exception {
.bean("destinationHeaderSetter")
.toF("%s:queue:override", componentScheme);
- fromF("%s:queue:xa", componentScheme)
+ fromF("%s:queue:xa?transactionManager=#jtaTransactionManager", componentScheme)
Review Comment:
Also it looks like only restrict with the IBM MQ client. Without the `transactionManager` property, it throws `MQRC_SYNCPOINT_NOT_AVAILABLE` error when starting to consume from a queue.
I test it with `artemis-jms-client` and it can work without this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] osmman commented on a diff in pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "osmman (via GitHub)" <gi...@apache.org>.
osmman commented on code in PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#discussion_r1308524583
##########
integration-tests/messaging/jms/src/main/java/org/apache/camel/quarkus/messaging/jms/JmsRoutes.java:
##########
@@ -44,11 +47,13 @@ public void configure() throws Exception {
.bean("destinationHeaderSetter")
.toF("%s:queue:override", componentScheme);
- fromF("%s:queue:xa", componentScheme)
+ fromF("%s:queue:xa?transactionManager=#jtaTransactionManager", componentScheme)
Review Comment:
Why only this one needs to bind transaction manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#issuecomment-1714887961
Hi @osmman , I update this PR and now it should work with `quarkus-pooled-jms:2.1.0`. Please can you take a review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] osmman commented on a diff in pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "osmman (via GitHub)" <gi...@apache.org>.
osmman commented on code in PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#discussion_r1308524583
##########
integration-tests/messaging/jms/src/main/java/org/apache/camel/quarkus/messaging/jms/JmsRoutes.java:
##########
@@ -44,11 +47,13 @@ public void configure() throws Exception {
.bean("destinationHeaderSetter")
.toF("%s:queue:override", componentScheme);
- fromF("%s:queue:xa", componentScheme)
+ fromF("%s:queue:xa?transactionManager=#jtaTransactionManager", componentScheme)
Review Comment:
Why only this one needs to bind transaction manager and not others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#discussion_r1308672225
##########
integration-tests/messaging/jms/src/main/java/org/apache/camel/quarkus/messaging/jms/JmsRoutes.java:
##########
@@ -44,11 +47,13 @@ public void configure() throws Exception {
.bean("destinationHeaderSetter")
.toF("%s:queue:override", componentScheme);
- fromF("%s:queue:xa", componentScheme)
+ fromF("%s:queue:xa?transactionManager=#jtaTransactionManager", componentScheme)
Review Comment:
Please refer to `camel-jms` document https://camel.apache.org/components/4.0.x/jms-component.html#_enabling_transacted_consumption
And for `JtaTransactionManager`, the propert `transacted=true` is not needed because the transaction is managed by the container like `quarkus-arc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223#issuecomment-1693174828
@osmman would you like to check this `IBMMQXATest` with the fix of `quarkus-pooled-jms`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #5223: Fix #5212 to add XA test for IBMMQ client
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng merged PR #5223:
URL: https://github.com/apache/camel-quarkus/pull/5223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org