You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/06/21 17:56:42 UTC
[jira] [Commented] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398509#comment-13398509 ]
Hadoop QA commented on HADOOP-8523:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532885/Hadoop-8523.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 13 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1130//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1130//console
This message is automatically generated.
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira