You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/08 10:24:54 UTC
[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #7710: Add test case for ShardingStrategyFactory
jacksparrow414 opened a new pull request #7710:
URL: https://github.com/apache/shardingsphere/pull/7710
Fixes #7707 .
Changes proposed in this pull request:
- add class named ShardingStrategyFactoryTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #7710: Add test case for ShardingStrategyFactory
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7710:
URL: https://github.com/apache/shardingsphere/pull/7710#issuecomment-705575392
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=h1) Report
> Merging [#7710](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a55e6a36cbe9475fdf5a0684a679b8820eb533ee?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7710 +/- ##
=========================================
Coverage 32.81% 32.82%
Complexity 2377 2377
=========================================
Files 1411 1411
Lines 104664 104664
Branches 9462 9462
=========================================
+ Hits 34348 34351 +3
+ Misses 67634 67632 -2
+ Partials 2682 2681 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7710/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
| [...arding/route/strategy/ShardingStrategyFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7710/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL3N0cmF0ZWd5L1NoYXJkaW5nU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (+57.14%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=footer). Last update [a55e6a3...e6058b1](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7710: Add test case for ShardingStrategyFactory
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7710:
URL: https://github.com/apache/shardingsphere/pull/7710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7710: Add test case for ShardingStrategyFactory
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7710:
URL: https://github.com/apache/shardingsphere/pull/7710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #7710: Add test case for ShardingStrategyFactory
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7710:
URL: https://github.com/apache/shardingsphere/pull/7710#issuecomment-705575392
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=h1) Report
> Merging [#7710](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a55e6a36cbe9475fdf5a0684a679b8820eb533ee?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7710 +/- ##
=========================================
Coverage 32.81% 32.82%
Complexity 2377 2377
=========================================
Files 1411 1411
Lines 104664 104664
Branches 9462 9462
=========================================
+ Hits 34348 34351 +3
+ Misses 67634 67632 -2
+ Partials 2682 2681 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7710/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
| [...arding/route/strategy/ShardingStrategyFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7710/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL3N0cmF0ZWd5L1NoYXJkaW5nU3RyYXRlZ3lGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (+57.14%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=footer). Last update [a55e6a3...e6058b1](https://codecov.io/gh/apache/shardingsphere/pull/7710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org