You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/10 22:41:24 UTC

[kudu-CR] sasl: don't use the 'client mech list' SASL option 

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5039

to review the following change.

Change subject: sasl: don't use the 'client_mech_list' SASL option
......................................................................

sasl: don't use the 'client_mech_list' SASL option

This option allows the client to specify which mechanisms it's willing
to negotiate. It turns out the option was added in Cyrus SASL 2.1.25,
which isn't available on el6.

While that option is useful, it's not doing anything magic: it just
filters the list of mechanisms that we pass from the server. This patch
just implements this filtering on our side.

This fixes the TestSaslRpc.TestNoMatchingMechanisms test case on el6.

Change-Id: I570a91e176803fdd0e4324e6f4443b8297ad0395
---
M src/kudu/rpc/sasl_client.cc
M src/kudu/rpc/sasl_helper.cc
2 files changed, 32 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5039/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I570a91e176803fdd0e4324e6f4443b8297ad0395
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] sasl: don't use the 'client mech list' SASL option

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: sasl: don't use the 'client_mech_list' SASL option
......................................................................


sasl: don't use the 'client_mech_list' SASL option

This option allows the client to specify which mechanisms it's willing
to negotiate. It turns out the option was added in Cyrus SASL 2.1.25,
which isn't available on el6.

While that option is useful, it's not doing anything magic: it just
filters the list of mechanisms that we pass from the server. This patch
just implements this filtering on our side.

This fixes the TestSaslRpc.TestNoMatchingMechanisms test case on el6.

Change-Id: I570a91e176803fdd0e4324e6f4443b8297ad0395
Reviewed-on: http://gerrit.cloudera.org:8080/5039
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/rpc/sasl_client.cc
M src/kudu/rpc/sasl_helper.cc
2 files changed, 32 insertions(+), 34 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I570a91e176803fdd0e4324e6f4443b8297ad0395
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] sasl: don't use the 'client mech list' SASL option

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: sasl: don't use the 'client_mech_list' SASL option
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I570a91e176803fdd0e4324e6f4443b8297ad0395
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No