[jira] [Commented] (BEAM-849) Redesign PipelineResult API

["Luke Cwik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812425#comment-15812425 ] 

Luke Cwik commented on BEAM-849:
--------------------------------

[~staslev], a user needs to understand that a Pipeline will be executing asynchronously which means the State from `getState()` can be stale or out of date as soon as it is returned. I would argue for returning state from `waitUntilFinish()` or `cancel()`. I would argue that in the case of timeout, `waitUntilFinish()` should throw an exception instead of returning `null` since the user requested for a terminal state yet we failed to do so.



> Redesign PipelineResult API
> ---------------------------
>
>                 Key: BEAM-849
>                 URL: https://issues.apache.org/jira/browse/BEAM-849
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Pei He
>
> Current state: 
> Jira https://issues.apache.org/jira/browse/BEAM-443 addresses waitUntilFinish() and cancel(). 
> However, there are additional work around PipelineResult: 
> need clearly defined contract and verification across all runners 
> need to revisit how to handle metrics/aggregators 
> need to be able to get logs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)