You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2026/09/08 07:27:20 UTC

[PR] [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter [spark]

HyukjinKwon opened a new pull request, #58601:
URL: https://github.com/apache/spark/pull/58601

   ### What changes were proposed in this pull request?
   
   Add an opt-in init parameter `requireExpiration` (default `false` = unchanged) to `JWSFilter`.
   When set to `true`, a token whose payload has no `exp` claim is rejected with `403`.
   
   ### Why are the changes needed?
   
   Lets a deployment require that JWS tokens carry an expiration, so a token cannot be presented
   indefinitely. Off by default, so there is no behavior change unless enabled.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No by default. When the new parameter is enabled, tokens without an `exp` claim are rejected.
   
   ### How was this patch tested?
   
   New `JWSFilterSuite` case: a token without an `exp` claim is rejected when the parameter is on.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Isaac
   
   This pull request and its description were written by Isaac.
   
   Co-authored-by: Isaac <no...@databricks.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #58601: [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter
URL: https://github.com/apache/spark/pull/58601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #58601:
URL: https://github.com/apache/spark/pull/58601#issuecomment-5593252590

   Merged to master, branch-4.x and branch-4.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #58601:
URL: https://github.com/apache/spark/pull/58601#issuecomment-5593239510

   Merged to master, branch-4.x and branch-4.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59320][UI] Optionally require an expiration claim in JWSFilter [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58601:
URL: https://github.com/apache/spark/pull/58601#issuecomment-5583510099

   Thank you @HyukjinKwon and @dongjoon-hyun! LG


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org