You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/19 20:18:30 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #7770: [AIRFLOW-7069] Fix CloudSQL system tests

turbaszek commented on a change in pull request #7770: [AIRFLOW-7069] Fix CloudSQL system tests
URL: https://github.com/apache/airflow/pull/7770#discussion_r395295628
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/cloud_sql.py
 ##########
 @@ -270,19 +263,18 @@ def patch_database(
         :type project_id: str
         :return: None
         """
-        if not project_id:
-            raise ValueError("The project_id should be set")
-        response = self.get_conn().databases().patch(  # pylint: disable=no-member
+        response = self.get_conn().databases().patch(  # noqa # pylint: disable=no-member
             project=project_id,
             instance=instance,
             database=database,
             body=body
         ).execute(num_retries=self.num_retries)
         operation_name = response["name"]
-        self._wait_for_operation_to_complete(project_id=project_id,
+        self._wait_for_operation_to_complete(project_id=project_id,  # type:ignore
                                              operation_name=operation_name)
 
     @CloudBaseHook.fallback_to_default_project_id
+    @CloudBaseHook.operation_in_progress_retry()
 
 Review comment:
   Do we need this () brackets?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services