You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/10 06:55:19 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #11638: fix: card thumbnails now always show border.
rusackas opened a new pull request #11638:
URL: https://github.com/apache/incubator-superset/pull/11638
Co-Authored-By: Evan Rusackas <ev...@preset.io>
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Cards (on any view, home page or dashboards list, for example) had the thumbnail image covering the cards' borders. This meant that images with white or gray backgrounds would look very odd. This PR makes some tweaks to allow the border to show at all times, and also adds the 1px horizontal rule between the thumbnail area and the footer, as per the original design.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before (two views)
<img width="999" alt="Screen Shot 2020-11-09 at 10 47 51 PM" src="https://user-images.githubusercontent.com/812905/98637901-f5176500-22dd-11eb-889b-fbc7803a406e.png">
<img width="988" alt="Screen Shot 2020-11-09 at 10 47 17 PM" src="https://user-images.githubusercontent.com/812905/98637907-f8aaec00-22dd-11eb-93b0-f40665ec94da.png">
After (same two views)
<img width="1004" alt="Screen Shot 2020-11-09 at 10 46 12 PM" src="https://user-images.githubusercontent.com/812905/98637925-fea0cd00-22dd-11eb-9aed-303ff68b01b1.png">
<img width="996" alt="Screen Shot 2020-11-09 at 10 45 24 PM" src="https://user-images.githubusercontent.com/812905/98637936-01032700-22de-11eb-8358-3eec6cb59f22.png">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
👀 visual validation
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #11624
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11638: fix: card thumbnails now always show border.
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11638:
URL: https://github.com/apache/incubator-superset/pull/11638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11638: fix: card thumbnails now always show border.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11638:
URL: https://github.com/apache/incubator-superset/pull/11638#issuecomment-724506119
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=h1) Report
> Merging [#11638](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=desc) (55cb68e) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `1.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11638 +/- ##
==========================================
- Coverage 62.26% 60.92% -1.35%
==========================================
Files 873 422 -451
Lines 42280 26284 -15996
Branches 3964 0 -3964
==========================================
- Hits 26326 16013 -10313
+ Misses 15774 10271 -5503
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `60.92% <ø> (-1.00%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.94% <0.00%> (-6.02%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11638/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=footer). Last update [4d41cf9...55cb68e](https://codecov.io/gh/apache/incubator-superset/pull/11638?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11638: fix: card thumbnails now always show border.
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11638:
URL: https://github.com/apache/incubator-superset/pull/11638#issuecomment-724839257
purrrrfect!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11638: fix: card thumbnails now always show border.
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11638:
URL: https://github.com/apache/incubator-superset/pull/11638#issuecomment-724832727
Superset does NOT have enough kittens... or GIFs... in PRs. I'll work to rectify the situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org