You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/10 14:32:52 UTC

[GitHub] [incubator-kvrocks] ShooterIT opened a new issue, #1082: Doubt about the HRANGE command

ShooterIT opened a new issue, #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Currently, we implement HRANGE command, but i think the name of it is suitable.
   
   For zset, we have `ZRANGEBYLEX` which could get members with lexicographical ordering,
   of course, `ZRANGE` has `BYLEX` option.
   HRANGE also get fields with lexicographical ordering, so i think its name should be
   `HRANGEBYLEX` aligned with `ZRANGEBYLEX`, otherwise, users may think it is similar
   with `ZRANGE` which `start` and `stop` are the position in it.
   
   What's more, i think the `min` and `max` arguments of `HRANGE` should start with
   ( or [, in order to specify if the range item is respectively exclusive or inclusive, also align
   with `ZRANGEBYLEX`
   
   
   ### Solution
   
   I suggest to change its name to HRANGEBYLEX and the `min` and `max` arguments of it
   should start with ( or [ 
   
   of course, we can implement HRANGE command with different options, but now, i think it
   is not urgent since there is no demand of it.
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice closed issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
PragmaTwice closed issue #1082: Doubt about the HRANGE command
URL: https://github.com/apache/incubator-kvrocks/issues/1082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tanruixiang commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1372179988

   > @tanruixiang Any update?
   
   I'm sorry for the long absence of updates due to illness. I will continue this work this weekend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tanruixiang commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1310509487

   I also misunderstood `start` and `stop` when I first started implementing them, and I'll correct that over the weekend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tanruixiang commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
tanruixiang commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1310531674

   > I also misunderstood `start` and `stop` when I first started implementing `HRANGE`.I'll add `hrange` and `hrangebylex` this weekend.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1372066897

   @tanruixiang Any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1372195465

   @tanruixiang Thanks for your feedback. No hurry, I'm just wondering if I missed anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1310457557

   Good point, currently `ZRANGE` and `HRANGE` have different semantics and argument types (integers v.s. strings), so I also think `ZRANGEBYLEX` is more concrete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1082: Doubt about the HRANGE command

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #1082:
URL: https://github.com/apache/incubator-kvrocks/issues/1082#issuecomment-1310415249

   This is an excellent proposition, from my side, I think the HRANGE command is similar to ZRANGE over ZRANGEBYLEX, so I regarded those parameters as `start` and `stop`. But I'm wondering if it's right to align them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org