You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2018/11/22 13:11:27 UTC
Review Request 69429: Introduce a Gradle build parameter to set the
default forkEvery value for the tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69429/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3408
https://issues.apache.org/jira/browse/SQOOP-3408
Repository: sqoop-trunk
Description
-------
Documented forkEvery.default in COMPILING.txt.
Needed to move the definition of the kerberizedTest task below tasks.withType(Test) block to preserve forkEvery 1 setting.
Diffs
-----
COMPILING.txt 0383707f689102a3a5777743d94646cfaaf21710
build.gradle 954935daeaaaf45e1b2fd83f74e11f5ed2d58377
Diff: https://reviews.apache.org/r/69429/diff/1/
Testing
-------
./gradlew test : runs the test task with forkEvery=0
./gradlew -DforkEvery.default=5 test : runs the test taks with forkEvery=5
./gradlew kerberizedTest : runs the kerberizedTest task with forkEvery=1
./gradlew -DforkEvery.default=5 kerberizedTest : runs the kerberizedTest task with forkEvery=1, so the forkEvery.default parameter does not affect kerberizedTest
Thanks,
Szabolcs Vasas
Re: Review Request 69429: Introduce a Gradle build parameter to set
the default forkEvery value for the tests
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69429/#review210798
-----------------------------------------------------------
Ship it!
Thanks Szabolcs for this improvement and the thorough documentation around it! Your change LGTM.
- Boglarka Egyed
On Nov. 22, 2018, 1:11 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69429/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 1:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3408
> https://issues.apache.org/jira/browse/SQOOP-3408
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documented forkEvery.default in COMPILING.txt.
> Needed to move the definition of the kerberizedTest task below tasks.withType(Test) block to preserve forkEvery 1 setting.
>
>
> Diffs
> -----
>
> COMPILING.txt 0383707f689102a3a5777743d94646cfaaf21710
> build.gradle 954935daeaaaf45e1b2fd83f74e11f5ed2d58377
>
>
> Diff: https://reviews.apache.org/r/69429/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test : runs the test task with forkEvery=0
> ./gradlew -DforkEvery.default=5 test : runs the test taks with forkEvery=5
>
> ./gradlew kerberizedTest : runs the kerberizedTest task with forkEvery=1
> ./gradlew -DforkEvery.default=5 kerberizedTest : runs the kerberizedTest task with forkEvery=1, so the forkEvery.default parameter does not affect kerberizedTest
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 69429: Introduce a Gradle build parameter to set
the default forkEvery value for the tests
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69429/#review210799
-----------------------------------------------------------
Ship it!
Ship It!
- Fero Szabo
On Nov. 22, 2018, 1:11 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69429/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 1:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3408
> https://issues.apache.org/jira/browse/SQOOP-3408
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documented forkEvery.default in COMPILING.txt.
> Needed to move the definition of the kerberizedTest task below tasks.withType(Test) block to preserve forkEvery 1 setting.
>
>
> Diffs
> -----
>
> COMPILING.txt 0383707f689102a3a5777743d94646cfaaf21710
> build.gradle 954935daeaaaf45e1b2fd83f74e11f5ed2d58377
>
>
> Diff: https://reviews.apache.org/r/69429/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test : runs the test task with forkEvery=0
> ./gradlew -DforkEvery.default=5 test : runs the test taks with forkEvery=5
>
> ./gradlew kerberizedTest : runs the kerberizedTest task with forkEvery=1
> ./gradlew -DforkEvery.default=5 kerberizedTest : runs the kerberizedTest task with forkEvery=1, so the forkEvery.default parameter does not affect kerberizedTest
>
>
> Thanks,
>
> Szabolcs Vasas
>
>