You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/10/13 06:11:31 UTC
[jira] Created: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
unnecessary SetWatches message on new session
---------------------------------------------
Key: ZOOKEEPER-551
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
Project: Zookeeper
Issue Type: Bug
Components: c client, java client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Priority: Minor
Fix For: 3.3.0
The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
even in the case of re-establishing session, however no watches are set. The code should check for watches before
sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-551:
---------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1. I just committed this one, Pat. Thanks!
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774483#action_12774483 ]
Hadoop QA commented on ZOOKEEPER-551:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12424236/ZOOKEEPER-551.patch
against trunk revision 833559.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/console
This message is automatically generated.
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774864#action_12774864 ]
Hudson commented on ZOOKEEPER-551:
----------------------------------
Integrated in ZooKeeper-trunk #528 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/528/])
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-551:
-----------------------------------
Assignee: Patrick Hunt
Status: Patch Available (was: Open)
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774891#action_12774891 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-551:
--------------------------------------------------
Committed revision 833932
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-551) unnecessary SetWatches message on
new session
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-551:
-----------------------------------
Attachment: ZOOKEEPER-551.patch
This patch changes the c/java code to not send setwatches message if there are no pending watches.
I don't see how to neg test this - we are already verifying the positive cases so failure for hadoopqa should be expected but I think that's ok.
> unnecessary SetWatches message on new session
> ---------------------------------------------
>
> Key: ZOOKEEPER-551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.