You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/02/27 08:21:46 UTC
[spark] branch branch-2.4 updated: [SPARK-23435][INFRA][FOLLOW-UP]
Remove unnecessary dependency in AppVeyor
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new a549a07 [SPARK-23435][INFRA][FOLLOW-UP] Remove unnecessary dependency in AppVeyor
a549a07 is described below
commit a549a07b9aec29f0c779125411a6c67b68cfafe7
Author: HyukjinKwon <gu...@apache.org>
AuthorDate: Thu Feb 27 00:18:46 2020 -0800
[SPARK-23435][INFRA][FOLLOW-UP] Remove unnecessary dependency in AppVeyor
### What changes were proposed in this pull request?
`testthat` version was pinned to `1.0.2` at https://github.com/apache/spark/commit/f15102b1702b64a54233ae31357e32335722f4e5 due to compatibility issue in SparkR.
The compatibility issue is finally fixed as of https://github.com/apache/spark/commit/298d0a5102e54ddc24f114e83d2b936762722eec and we now use testthat latest version.
Now we don't need to install `crayon', 'praise' and 'R6' as they are dependences in testthat (https://github.com/r-lib/testthat/blob/master/DESCRIPTION).
### Why are the changes needed?
To minimise build specification and prevent dependency confusion.
### Does this PR introduce any user-facing change?
No. Dev only change.
### How was this patch tested?
AppVeyor build will test it out.
Closes #27717 from HyukjinKwon/SPARK-23435-followup.
Authored-by: HyukjinKwon <gu...@apache.org>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
(cherry picked from commit b2a74107d50a0f69d727049581e01d9e2f6b4778)
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
appveyor.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 326845d..d9ca5b5 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -42,8 +42,7 @@ install:
# Install maven and dependencies
- ps: .\dev\appveyor-install-dependencies.ps1
# Required package for R unit tests
- - cmd: R -e "install.packages(c('knitr', 'rmarkdown', 'e1071', 'survival', 'arrow'), repos='https://cloud.r-project.org/')"
- - cmd: R -e "install.packages(c('crayon', 'praise', 'R6', 'testthat'), repos='https://cloud.r-project.org/')"
+ - cmd: R -e "install.packages(c('knitr', 'rmarkdown', 'testthat', 'e1071', 'survival', 'arrow'), repos='https://cloud.r-project.org/')"
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown'); packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival'); packageVersion('arrow')"
build_script:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org