You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Adrian Cumiskey (Created) (JIRA)" <ji...@apache.org> on 2011/10/29 21:57:32 UTC
[jira] [Created] (OGNL-35) [PATCH] Improvements to
{List,Map}PropertyAccessor
[PATCH] Improvements to {List,Map}PropertyAccessor
--------------------------------------------------
Key: OGNL-35
URL: https://issues.apache.org/jira/browse/OGNL-35
Project: OGNL
Issue Type: Improvement
Reporter: Adrian Cumiskey
Priority: Minor
* Flipped equals() where variable is tested against String constant.
* CPD: Extracted getSourceBeanMethod() shared method from getSourceSetter() and getSourceAccessor() in ListPropertyAccessor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Adrian Cumiskey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cumiskey updated OGNL-35:
--------------------------------
Description:
* Flipped equals() everywhere where a variable is tested against a String constant.
* ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
* ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
* ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
was:
* Flipped equals() where variable is tested against String constant.
* CPD: Extracted getSourceBeanMethod() shared method from getSourceSetter() and getSourceAccessor() in ListPropertyAccessor
Summary: [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty (was: [PATCH] Improvements to {List,Map}PropertyAccessor)
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Maurizio Cucchiara (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maurizio Cucchiara resolved OGNL-35.
------------------------------------
Resolution: Fixed
Assignee: Maurizio Cucchiara
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143866#comment-13143866 ]
Hudson commented on OGNL-35:
----------------------------
Integrated in ognl #184 (See [https://builds.apache.org/job/ognl/184/])
OGNL-35 - Flipped equals() everywhere where a variable is tested against a String constant.
OGNL-35 - CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
OGNL-35 - CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197452
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/MapPropertyAccessor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197448
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ListPropertyAccessor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197443
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Adrian Cumiskey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143700#comment-13143700 ]
Adrian Cumiskey commented on OGNL-35:
-------------------------------------
patch-OGNL35-v2.txt improves upon and replaces the original one.
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143844#comment-13143844 ]
Hudson commented on OGNL-35:
----------------------------
Integrated in ognl #183 (See [https://builds.apache.org/job/ognl/183/])
OGNL-35 - CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197437
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-35) [PATCH] Improvements to
{List,Map}PropertyAccessor
Posted by "Adrian Cumiskey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cumiskey updated OGNL-35:
--------------------------------
Attachment: patch-OGNL35.txt
> [PATCH] Improvements to {List,Map}PropertyAccessor
> --------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35.txt
>
>
> * Flipped equals() where variable is tested against String constant.
> * CPD: Extracted getSourceBeanMethod() shared method from getSourceSetter() and getSourceAccessor() in ListPropertyAccessor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Maurizio Cucchiara (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143875#comment-13143875 ]
Maurizio Cucchiara commented on OGNL-35:
----------------------------------------
Thanks Adrian for the patch.
Just a little note: next time, could you please follow the [maven code style|http://maven.apache.org/developers/conventions/code.html] conventions?
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Adrian Cumiskey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cumiskey updated OGNL-35:
--------------------------------
Attachment: patch-OGNL35-v2.txt
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Adrian Cumiskey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144870#comment-13144870 ]
Adrian Cumiskey commented on OGNL-35:
-------------------------------------
Sure, sorry about this. I have installed them in IntelliJ now :-).
Cheers, Adrian.
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to
{List,Map,Array}PropertyAccessor and ASTProperty
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143882#comment-13143882 ]
Hudson commented on OGNL-35:
----------------------------
Integrated in ognl #185 (See [https://builds.apache.org/job/ognl/185/])
Added OGNL-35 to the change list
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197467
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira