You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andrelmartins (via GitHub)" <gi...@apache.org> on 2023/09/29 17:46:53 UTC

[GitHub] [arrow-datafusion] andrelmartins opened a new pull request, #7703: Extend infer_placeholder_types to support BETWEEN predicates

andrelmartins opened a new pull request, #7703:
URL: https://github.com/apache/arrow-datafusion/pull/7703

   ## Which issue does this PR close?
   
   Closes #7702.
   
   ## Rationale for this change
   
   ## What changes are included in this PR?
   
   Add extra inference code for BETWEEN predicate.
   
   ## Are these changes tested?
   
   Unit test in code.
   
   ## Are there any user-facing changes?
   
   Parameter type inference now works with statements like `SELECT ... WHERE col BETWEEN $1 AND $2`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #7703: Extend infer_placeholder_types to support BETWEEN predicates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7703:
URL: https://github.com/apache/arrow-datafusion/pull/7703#issuecomment-1741330927

   Thank you @andrelmartins  -- this looks like a nice improvement to me ❤️  -- I kicked off the CI jobs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #7703: Extend infer_placeholder_types to support BETWEEN predicates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7703:
URL: https://github.com/apache/arrow-datafusion/pull/7703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #7703: Extend infer_placeholder_types to support BETWEEN predicates

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7703:
URL: https://github.com/apache/arrow-datafusion/pull/7703#issuecomment-1742041674

   CI was failing due to https://github.com/apache/arrow-datafusion/issues/7705. I think if you merge the branch up from main the CI will pass.
   
   Thanks again @andrelmartins 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org