You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 01:52:56 UTC
[GitHub] [incubator-superset] pablo-tech opened a new pull request #12238: Update index.mdx
pablo-tech opened a new pull request #12238:
URL: https://github.com/apache/incubator-superset/pull/12238
Superset -> Pinot connection fix
### SUMMARY
The pinot Pinot connection instructions mention the CONTROLLER twice, but in one of those it should be the BROKER instead
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Per the ApachePinot here https://docs.pinot.apache.org/integrations/superset
### ADDITIONAL INFORMATION
Only impacts the Superset website drivers instructions page https://superset.apache.org/docs/databases/installing-database-drivers
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12238: Update index.mdx
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12238:
URL: https://github.com/apache/incubator-superset/pull/12238#discussion_r551415791
##########
File path: docs/src/pages/docs/Connecting to Databases/index.mdx
##########
@@ -29,7 +29,7 @@ A list of some of the recommended packages.
|[Apache Hive](/docs/databases/hive)|```pip install pyhive```|```hive://hive@{hostname}:{port}/{database}```|
|[Apache Impala](/docs/databases/impala)|```pip install impala```|```impala://{hostname}:{port}/{database}```|
|[Apache Kylin](/docs/databases/kylin)|```pip install kylinpy```|```kylin://<username>:<password>@<hostname>:<port>/<project>?<param1>=<value1>&<param2>=<value2>```|
-|[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://CONTROLLER:5436/ query?server=http://CONTROLLER:5983/```|
+|[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://BROKER:5436/query?server=http://CONTROLLER:5983/```|
Review comment:
reading the Pinot docs, it looks like maybe this should be `pinot://` instead of `pinot+http://`, do you think that change should be made here too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org