You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:55:20 UTC

[GitHub] [airflow] olivermeyer commented on pull request #16395: Use AirflowJsonEncoder in BaseXCom.serialize_value

olivermeyer commented on pull request #16395:
URL: https://github.com/apache/airflow/pull/16395#issuecomment-860226103


   > LGTM but I would love to have someone more familiar with the encoder to verify if there are no side effects ? Things like performance and some potential serialize/deserialize compatibility come to mind immmediately.
   
   Thanks for reviewing. Do you know who is familiar with the encoder and could take a look?
   
   Also, CI says `The PR likely needs to run all tests!` - is that the case? If yes, I'll amend and force-push. If not, is there a way to trigger CI without force-pushing? One of the tests failed but it passes locally so could be a transient error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org