You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/15 21:19:30 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #484: [YUNIKORN-1459] Use priority for application sorting
craigcondit opened a new pull request, #484:
URL: https://github.com/apache/yunikorn-core/pull/484
### What is this PR for?
Use priority when sorting application requests.
WIP until YUNIKORN-1458 merges.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1459
### How should this be tested?
Unit tests added.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #484: [YUNIKORN-1459] Use priority for application sorting
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #484:
URL: https://github.com/apache/yunikorn-core/pull/484#issuecomment-1353725798
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/yunikorn-core/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (930f335) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/43e656aabc35ea3e879162244f37a270704ba91b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43e656a) will **increase** coverage by `0.42%`.
> The diff coverage is `94.89%`.
```diff
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 72.77% 73.20% +0.42%
==========================================
Files 69 69
Lines 10207 10422 +215
==========================================
+ Hits 7428 7629 +201
- Misses 2533 2543 +10
- Partials 246 250 +4
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/yunikorn-core/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `86.62% <ø> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `73.74% <90.32%> (+1.37%)` | :arrow_up: |
| [pkg/scheduler/objects/sorters.go](https://codecov.io/gh/apache/yunikorn-core/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlcnMuZ28=) | `97.00% <95.41%> (-3.00%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.30% <100.00%> (+1.51%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `77.37% <100.00%> (+0.06%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on pull request #484: [YUNIKORN-1459] Use priority for application sorting
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #484:
URL: https://github.com/apache/yunikorn-core/pull/484#issuecomment-1357335620
Rebased on latest master. Minor change to .golangci.yaml required to fix lint crashing with panic (seems related to the recent zap logger upgrade).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #484: [YUNIKORN-1459] Use priority for application sorting
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #484:
URL: https://github.com/apache/yunikorn-core/pull/484#issuecomment-1357208477
This probably needs a rebase before we proceed.
First look at the code all looks good, just waiting with the approval until we have rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #484: [YUNIKORN-1459] Use priority for application sorting
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #484: [YUNIKORN-1459] Use priority for application sorting
URL: https://github.com/apache/yunikorn-core/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org