You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "danielcweeks (via GitHub)" <gi...@apache.org> on 2023/03/10 18:26:58 UTC

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #7064: Core: Allow customizing FileIO in REST catalog

danielcweeks commented on code in PR #7064:
URL: https://github.com/apache/iceberg/pull/7064#discussion_r1132731306


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -116,6 +122,11 @@ public void initialize(String name, Map<String, String> properties) {
     }
   }
 
+  public void setFileIOBuilder(Function<Map<String, String>, FileIO> ioBuilder) {

Review Comment:
   Seeing as how we're duplicating this API across some catalogs, should we pull the set/create into an interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org