You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Andrei Dulceanu (Jira)" <ji...@apache.org> on 2019/11/08 11:29:00 UTC
[jira] [Resolved] (OAK-8750) SegmentStoreMigrator should catch and
log exceptions thrown while migrating archives
[ https://issues.apache.org/jira/browse/OAK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Dulceanu resolved OAK-8750.
----------------------------------
Resolution: Fixed
Fixed in trunk at r1869544.
> SegmentStoreMigrator should catch and log exceptions thrown while migrating archives
> ------------------------------------------------------------------------------------
>
> Key: OAK-8750
> URL: https://issues.apache.org/jira/browse/OAK-8750
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-azure
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Major
> Fix For: 1.20.0
>
> Attachments: OAK-8750.patch
>
>
> Current logic used in migrating archives in {{SegmentStoreMigrator}} silently swallows exceptions coming from the segment, binary refs and graph migration methods:
> {noformat}
> try (SegmentArchiveReader reader = sourceManager.forceOpen(archiveName)) {
> SegmentArchiveWriter writer = targetManager.create(archiveName);
> try {
> migrateSegments(reader, writer);
> migrateBinaryRef(reader, writer);
> migrateGraph(reader, writer);
> } finally {
> writer.close();
> }
> }
> {noformat}
> Adding a catch block which logs the possible exceptions would make analysing logs easier.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)