You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/24 13:18:17 UTC

[GitHub] [spark] rvesse opened a new pull request #24449: [SPARK-26729][K8S] Fix typo with default value for R image name

rvesse opened a new pull request #24449: [SPARK-26729][K8S] Fix typo with default value for R image name
URL: https://github.com/apache/spark/pull/24449
 
 
   ## What changes were proposed in this pull request?
   
   As discovered by users making use of this feature, there is a bug in the
   declaration of the R_IMAGE_NAME variable that causes the default name to
   not be properly set to spark-r but rather to just -r
   
   ## How was this patch tested?
   
   Verified that the image name for the R image is now appropriately populated in the integration test script via Bash debug output.
   
   NB - The fact that this wasn't spotted earlier highlights the fact that currently the K8S integration test suite does not have any tests for the R image as if it had this would have failed integration testing in the original PR #23846 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org