[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4209: [CARBONDATA-4278] Avoid refetching all indexes to get segment properties

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #4209:
URL: https://github.com/apache/carbondata/pull/4209#discussion_r699953757



##########
File path: core/src/main/java/org/apache/carbondata/core/index/TableIndex.java
##########
@@ -207,15 +208,22 @@ public CarbonTable getTable() {
       Map<Segment, List<Index>> indexes) throws IOException {
     Set<String> missingSISegments = filter.getMissingSISegments();
     for (Segment segment : segments) {
+      List<Index> segmentIndices = indexes.get(segment);
       if (segment == null ||
-          indexes.get(segment) == null || indexes.get(segment).isEmpty()) {
+          indexes.get(segment) == null || segmentIndices.isEmpty()) {

Review comment:
       In line 213, `indexes.get(segment)` is called again. Avoid it by using the existing result from `segmentIndices`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org