You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/05 09:40:00 UTC
[GitHub] [hbase] bsglz opened a new pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
bsglz opened a new pull request #2202:
URL: https://github.com/apache/hbase/pull/2202
…nually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670602243
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 51s | master passed |
| +1 :green_heart: | compile | 2m 59s | master passed |
| +1 :green_heart: | shadedjars | 6m 7s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 54s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 2m 58s | the patch passed |
| +1 :green_heart: | javac | 2m 58s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 0s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 52s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. |
| -1 :x: | unit | 210m 33s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 5m 24s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 8m 41s | hbase-shell in the patch passed. |
| | | 260m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b668cbf37022 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 485e0d2fa4 |
| Default Java | 1.8.0_232 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/testReport/ |
| Max. process+thread count | 3364 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-678916178
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 20s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 1s | master passed |
| +1 :green_heart: | compile | 3m 27s | master passed |
| +1 :green_heart: | shadedjars | 5m 48s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 52s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 1s | the patch passed |
| +1 :green_heart: | compile | 3m 28s | the patch passed |
| +1 :green_heart: | javac | 3m 28s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 50s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 58s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. |
| -1 :x: | unit | 136m 31s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 4m 50s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 7m 10s | hbase-shell in the patch passed. |
| | | 186m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux bee7b347c44f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9f62a82334 |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/testReport/ |
| Max. process+thread count | 4268 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670371077
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 39s | master passed |
| +1 :green_heart: | checkstyle | 2m 56s | master passed |
| +1 :green_heart: | spotbugs | 8m 37s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 50s | the patch passed |
| -0 :warning: | checkstyle | 1m 13s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 14s | The patch generated 3 new + 363 unchanged - 0 fixed = 366 total (was 363) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 35s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 2m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 29s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. |
| | | 55m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux a7e6880fd757 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9b49bd6b66 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467867207
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
What do you think of just continue, since the region is not online(maybe closed or moved), anyway we will not lost data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468348209
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
Or throw a Exception to client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670565450
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 1s | master passed |
| +1 :green_heart: | compile | 3m 27s | master passed |
| +1 :green_heart: | shadedjars | 5m 45s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 50s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 56s | the patch passed |
| +1 :green_heart: | compile | 3m 28s | the patch passed |
| +1 :green_heart: | javac | 3m 28s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 55s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-client in the patch passed. |
| -1 :x: | unit | 131m 19s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 4m 55s | hbase-thrift in the patch passed. |
| -1 :x: | unit | 7m 6s | hbase-shell in the patch failed. |
| | | 180m 27s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c9a5b8211aec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 485e0d2fa4 |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/testReport/ |
| Max. process+thread count | 4314 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] tedyu commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
tedyu commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-677026633
I am a bit busy recently.
Please find another committer to review.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669170851
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 10s | master passed |
| +1 :green_heart: | compile | 3m 26s | master passed |
| +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 48s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 2s | the patch passed |
| +1 :green_heart: | compile | 3m 31s | the patch passed |
| +1 :green_heart: | javac | 3m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 45s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 50s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 132m 29s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 4m 54s | hbase-thrift in the patch passed. |
| -1 :x: | unit | 7m 3s | hbase-shell in the patch failed. |
| | | 182m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 894c8425c19f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d2f5a5f27b |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/testReport/ |
| Max. process+thread count | 4271 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-671175273
PTAL if you have time. Thanks. @tedyu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467859341
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Will fix later. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r466832116
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -1312,6 +1312,14 @@ default boolean abortProcedure(long procId, boolean mayInterruptIfRunning) throw
*/
void rollWALWriter(ServerName serverName) throws IOException, FailedLogCloseException;
+ /**
+ * Archive the earliest log file.
+ *
+ * @param serverName The servername of the regionserver.
+ * @throws IOException if a remote or network exception occurs
+ */
+ void archiveWAL(ServerName serverName) throws IOException;
Review comment:
Good point, will fix later.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669657366
The remained checkstyle issue is unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-671891598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 28s | master passed |
| +1 :green_heart: | checkstyle | 2m 40s | master passed |
| +1 :green_heart: | spotbugs | 7m 26s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 24s | the patch passed |
| -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 12s | The patch generated 3 new + 364 unchanged - 0 fixed = 367 total (was 364) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 2m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 7s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 1s | The patch does not generate ASF License warnings. |
| | | 52m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux ddbcf363eb06 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6fd7dcef28 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468346230
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Checked the existing api in Admin.java, such as flushRegion, compactRegion, seems currently we dont use status, if there is something wrong at server side, we notice client by throw ServiceException.
Though the FlushRegionResponse has a flushed flag, but does not be used at client.
Maybe we should keep consist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670462234
rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669207083
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 0s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 55s | master passed |
| +1 :green_heart: | compile | 3m 1s | master passed |
| +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 43s | the patch passed |
| +1 :green_heart: | compile | 2m 59s | the patch passed |
| +1 :green_heart: | javac | 2m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 52s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 203m 30s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 18s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 8m 32s | hbase-shell in the patch passed. |
| | | 252m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 3fc54869ef7f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d2f5a5f27b |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/testReport/ |
| Max. process+thread count | 3517 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-671974773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 2s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 37s | master passed |
| +1 :green_heart: | compile | 2m 59s | master passed |
| +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 59s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 26s | the patch passed |
| +1 :green_heart: | compile | 3m 0s | the patch passed |
| +1 :green_heart: | javac | 3m 0s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 156m 20s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 16s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 7m 38s | hbase-shell in the patch passed. |
| | | 203m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2dc3f9b12ad6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6fd7dcef28 |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/testReport/ |
| Max. process+thread count | 4402 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669653892
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 4s | master passed |
| +1 :green_heart: | checkstyle | 3m 6s | master passed |
| +1 :green_heart: | spotbugs | 8m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 46s | the patch passed |
| -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 13s | The patch generated 3 new + 363 unchanged - 0 fixed = 366 total (was 363) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 44s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 3m 5s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 12s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. |
| | | 57m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux 55c351077c11 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c39cad220d |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-676882950
Ping. @tedyu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670424980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 12s | master passed |
| +1 :green_heart: | compile | 3m 31s | master passed |
| +1 :green_heart: | shadedjars | 5m 44s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 38s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 1s | the patch passed |
| +1 :green_heart: | compile | 3m 28s | the patch passed |
| +1 :green_heart: | javac | 3m 28s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 28s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 50s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-client in the patch passed. |
| -1 :x: | unit | 131m 36s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 4m 53s | hbase-thrift in the patch passed. |
| -1 :x: | unit | 7m 5s | hbase-shell in the patch failed. |
| | | 181m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 26213e52cd18 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9b49bd6b66 |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/testReport/ |
| Max. process+thread count | 4039 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-678942484
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 23s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 57s | master passed |
| +1 :green_heart: | compile | 2m 57s | master passed |
| +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 53s | the patch passed |
| +1 :green_heart: | compile | 3m 0s | the patch passed |
| +1 :green_heart: | javac | 3m 0s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 58s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 201m 35s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 12s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 8m 32s | hbase-shell in the patch passed. |
| | | 256m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 5093b4b89147 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9f62a82334 |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/testReport/ |
| Max. process+thread count | 3740 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467884486
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Thought again, it should be a common name if we want to improve it in future, such as archive a specify log file, archive all log files, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669696044
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 21s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 16s | master passed |
| +1 :green_heart: | compile | 3m 30s | master passed |
| +1 :green_heart: | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 1s | the patch passed |
| +1 :green_heart: | compile | 3m 26s | the patch passed |
| +1 :green_heart: | javac | 3m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 43s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 131m 44s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 4m 22s | hbase-thrift in the patch passed. |
| -1 :x: | unit | 7m 58s | hbase-shell in the patch failed. |
| | | 182m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6893faa9f206 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c39cad220d |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/testReport/ |
| Max. process+thread count | 4232 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] tedyu commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
tedyu commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r466812559
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -1312,6 +1312,14 @@ default boolean abortProcedure(long procId, boolean mayInterruptIfRunning) throw
*/
void rollWALWriter(ServerName serverName) throws IOException, FailedLogCloseException;
+ /**
+ * Archive the earliest log file.
+ *
+ * @param serverName The servername of the regionserver.
+ * @throws IOException if a remote or network exception occurs
+ */
+ void archiveWAL(ServerName serverName) throws IOException;
Review comment:
Should method name reflect that the earliest log is archived ?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -883,6 +884,20 @@ public static RollWALWriterRequest buildRollWALWriterRequest() {
return ROLL_WAL_WRITER_REQUEST;
}
+ /**
+ * @see #buildArchiveWALRequest()
+ */
+ private static ArchiveWALRequest ARCHIVE_WAL_REQUEST = ArchiveWALRequest.newBuilder()
+ .build();
+
+ /**
+ * Create a new ArchiveWALRequest
Review comment:
No new request is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-672261310
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 5s | master passed |
| +1 :green_heart: | checkstyle | 3m 17s | master passed |
| +1 :green_heart: | spotbugs | 9m 21s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 39s | the patch passed |
| -0 :warning: | checkstyle | 1m 30s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 15s | The patch generated 3 new + 364 unchanged - 0 fixed = 367 total (was 364) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 14m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 3m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 10m 33s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 1s | The patch does not generate ASF License warnings. |
| | | 67m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux 3bb169349d8a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ea130249ae |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 84 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670505620
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 28s | master passed |
| +1 :green_heart: | checkstyle | 2m 54s | master passed |
| +1 :green_heart: | spotbugs | 7m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 27s | the patch passed |
| -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 12s | The patch generated 3 new + 364 unchanged - 0 fixed = 367 total (was 364) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 10s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 2m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 7s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 1s | The patch does not generate ASF License warnings. |
| | | 52m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux cadcee66b0d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 485e0d2fa4 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-677044948
> I am a bit busy recently.
>
> Please find another committer to review.
>
> Thanks
Ok, thanks all the same for the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468346230
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Checked the existing api in Admin.java, such as flushRegion, compactRegion, seems currently we dont use status, if there is something wrong at server side, we notice client by throw ServiceException.
Though the FlushRegionResponse has a flushed flag, but does not be used at client.
Maybe we should keep consistent?
Thanks for comment. @tedyu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-672387820
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 46s | master passed |
| +1 :green_heart: | compile | 4m 53s | master passed |
| +1 :green_heart: | shadedjars | 7m 40s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 30s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 53s | hbase-server in master failed. |
| -0 :warning: | javadoc | 1m 10s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 27s | the patch passed |
| +1 :green_heart: | compile | 4m 36s | the patch passed |
| +1 :green_heart: | javac | 4m 36s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 29s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 29s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 1m 8s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 16s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 36s | hbase-client in the patch passed. |
| -1 :x: | unit | 222m 20s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 5m 36s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 7m 17s | hbase-shell in the patch passed. |
| | | 287m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2f578faa3f0f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ea130249ae |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/testReport/ |
| Max. process+thread count | 3344 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] tedyu commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
tedyu commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467946140
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
I think ArchiveWALResponse should contain the status of archival (including error).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468348209
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
Or throw an Exception to client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467872567
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
When region close, the onRegionClose of SequenceIdAccounting should be called, so its regions will consist with onlineRegions in HRegionServer, if not, there must be something wrong, then the onlineRegions shall prevail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467887082
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
If it make sense, i will remove the "earliest" from method name also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669120579
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 54s | master passed |
| +1 :green_heart: | checkstyle | 2m 48s | master passed |
| +1 :green_heart: | spotbugs | 8m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| -0 :warning: | checkstyle | 0m 31s | hbase-client: The patch generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107) |
| -0 :warning: | checkstyle | 1m 18s | hbase-server: The patch generated 5 new + 68 unchanged - 0 fixed = 73 total (was 68) |
| -0 :warning: | rubocop | 0m 14s | The patch generated 4 new + 363 unchanged - 0 fixed = 367 total (was 363) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 13m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 3m 12s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 7s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 3s | The patch does not generate ASF License warnings. |
| | | 60m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux ffabfb0572e0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d2f5a5f27b |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-670456147
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 19s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 12s | master passed |
| +1 :green_heart: | compile | 2m 58s | master passed |
| +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 46s | the patch passed |
| +1 :green_heart: | compile | 2m 58s | the patch passed |
| +1 :green_heart: | javac | 2m 58s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. |
| -1 :x: | unit | 209m 43s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 5m 30s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 8m 34s | hbase-shell in the patch passed. |
| | | 260m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f22973ac76d6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9b49bd6b66 |
| Default Java | 1.8.0_232 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/testReport/ |
| Max. process+thread count | 3549 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468346230
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Checked the existing api in Admin.java, such as flushRegion, compactRegion, seems currently we dont use status, if there is something wrong at server side, we notice client by throw ServiceException.
Though the FlushRegionResponse has a flushed flag, but does not be used at client.
Maybe we should keep consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467861084
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
+ }
+ r.flushcache(entry.getValue(), false, FlushLifeCycleTracker.DUMMY);
+ }
+ }
+ // move the log file to archive dir
+ this.totalLogSize.addAndGet(-firstWALEntry.getValue().logSize);
+ moveLogFileToArchiveDir(firstWALEntry.getKey());
Review comment:
Good point, the move action should be called first.
BTW, this part copied from existing code, maybe need a follow-on jira to fix it too.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468348209
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
Or throw an Exception to notice client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-672326267
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 47s | master passed |
| +1 :green_heart: | compile | 3m 5s | master passed |
| +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 59s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 32s | the patch passed |
| +1 :green_heart: | compile | 3m 1s | the patch passed |
| +1 :green_heart: | javac | 3m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 143m 13s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 6s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 7m 9s | hbase-shell in the patch passed. |
| | | 190m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6aaaef67c1ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ea130249ae |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/testReport/ |
| Max. process+thread count | 4202 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] tedyu commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
tedyu commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467843318
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Should this be renamed to go with the updated method name ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
+ }
+ r.flushcache(entry.getValue(), false, FlushLifeCycleTracker.DUMMY);
+ }
+ }
+ // move the log file to archive dir
+ this.totalLogSize.addAndGet(-firstWALEntry.getValue().logSize);
+ moveLogFileToArchiveDir(firstWALEntry.getKey());
Review comment:
What if IOException is thrown from this call ?
Would totalLogSize be correct ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -872,6 +874,33 @@ private IOException convertInterruptedExceptionToIOException(final InterruptedEx
}
}
+ public void archive(RegionServerServices services) throws IOException{
+ if (getNumRolledLogFiles() < 1) {
+ return;
+ }
+ // get the earliest log of this WAL instance
+ Map.Entry<Path, WalProps> firstWALEntry = this.walFile2Props.firstEntry();
+ // flush reigons if necessary
+ Map<byte[], List<byte[]>> regions =
+ this.sequenceIdAccounting.findLower(firstWALEntry.getValue().encodedName2HighestSequenceId);
+ if (regions != null) {
+ for (Map.Entry<byte[], List<byte[]>> entry : regions.entrySet()) {
+ String encodedRegionName = Bytes.toString(entry.getKey());
+ HRegion r = (HRegion) services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to flush of {} when archive manually, because it is not online on us",
+ encodedRegionName);
+ return;
Review comment:
It seems the return value should not be void - otherwise the caller wouldn't know this scenario (region not found).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-671175005
The failure seems unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-672007461
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 50s | master passed |
| +1 :green_heart: | compile | 3m 39s | master passed |
| +1 :green_heart: | shadedjars | 6m 21s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 58s | hbase-thrift in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 27s | the patch passed |
| +1 :green_heart: | compile | 3m 38s | the patch passed |
| +1 :green_heart: | javac | 3m 38s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 56s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 2s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 20s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 195m 0s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 12s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 7m 55s | hbase-shell in the patch passed. |
| | | 248m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2a724d5b2ae6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6fd7dcef28 |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/testReport/ |
| Max. process+thread count | 2905 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-669729667
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 2s | master passed |
| +1 :green_heart: | compile | 3m 8s | master passed |
| +1 :green_heart: | shadedjars | 6m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 49s | the patch passed |
| +1 :green_heart: | compile | 3m 8s | the patch passed |
| +1 :green_heart: | javac | 3m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 1s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 48s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 215m 33s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 5m 29s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 8m 39s | hbase-shell in the patch passed. |
| | | 266m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4113cf9b6edb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c39cad220d |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/testReport/ |
| Max. process+thread count | 3810 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#issuecomment-678885710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 49s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 27s | master passed |
| +1 :green_heart: | checkstyle | 2m 55s | master passed |
| +1 :green_heart: | spotbugs | 7m 25s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 20s | the patch passed |
| -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) |
| -0 :warning: | rubocop | 0m 12s | The patch generated 3 new + 372 unchanged - 0 fixed = 375 total (was 372) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 4s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | hbaseprotoc | 2m 52s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 8s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. |
| | | 55m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2202 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop |
| uname | Linux 7c66e055fe3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9f62a82334 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r466831152
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -883,6 +884,20 @@ public static RollWALWriterRequest buildRollWALWriterRequest() {
return ROLL_WAL_WRITER_REQUEST;
}
+ /**
+ * @see #buildArchiveWALRequest()
+ */
+ private static ArchiveWALRequest ARCHIVE_WAL_REQUEST = ArchiveWALRequest.newBuilder()
+ .build();
+
+ /**
+ * Create a new ArchiveWALRequest
Review comment:
Will fix later.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467976296
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
> I think ArchiveWALResponse should contain the status of archival (including error).
Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r467884486
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
repeated bytes region_to_flush = 1;
}
+message ArchiveWALRequest {
Review comment:
Thought again, it should be a common name if we want to improve it in future, such as archive a specify log file, archive all log files, etc.
WDYT? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org